comphead commented on PR #14575:
URL: https://github.com/apache/datafusion/pull/14575#issuecomment-2652071549
Thanks @wForget and @alamb for finding a bench
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
comphead merged PR #14575:
URL: https://github.com/apache/datafusion/pull/14575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dataf
alamb commented on PR #14575:
URL: https://github.com/apache/datafusion/pull/14575#issuecomment-2650931710
(BTW I run benchmarks using
https://github.com/alamb/datafusion-benchmarking/blob/main/compare_branch_bench.sh)
--
This is an automated message from the Apache Git Service.
To respon
alamb commented on code in PR #14575:
URL: https://github.com/apache/datafusion/pull/14575#discussion_r1950877830
##
datafusion/functions/src/string/repeat.rs:
##
@@ -130,22 +142,36 @@ fn repeat(args: &[ArrayRef]) -> Result {
}
}
-fn repeat_impl<'a, T, S>(string_array: S
wForget commented on PR #14575:
URL: https://github.com/apache/datafusion/pull/14575#issuecomment-2649905045
> thanks @wForget I feel it is great to avoid fallible scenario. Please
create a bench like for other string functions to see if we get a performance
downside introducing new branch
wForget opened a new pull request, #14575:
URL: https://github.com/apache/datafusion/pull/14575
## Which issue does this PR close?
minor fix
## Rationale for this change
Check string size overflow before string repeat build to fail fast and save
memory.
## What ch
