wForget commented on PR #14575: URL: https://github.com/apache/datafusion/pull/14575#issuecomment-2649905045
> thanks @wForget I feel it is great to avoid fallible scenario. Please create a bench like for other string functions to see if we get a performance downside introducing new branch instructions like IF @comphead Thank you, I have tried to add a benchmark case. Before this fix, string repeat overflow would result in a panic error which interrupts the benchmark, so it is difficult for me to compare whether the new benchmark has an improvement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
