alamb commented on PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#issuecomment-2648008182
Thanks everyone! This is epic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
alamb merged PR #14521:
URL: https://github.com/apache/datafusion/pull/14521
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
eliaperantoni commented on code in PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#discussion_r1948557193
##
datafusion/sql/tests/cases/diagnostic.rs:
##
@@ -201,14 +201,8 @@ fn test_ambiguous_reference() -> Result<()> {
let diag = do_query(query);
asse
alamb commented on PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#issuecomment-2646172628
I merged up from main to resolve a conflict with this branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
comphead commented on code in PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#discussion_r1946765159
##
datafusion/sql/tests/cases/diagnostic.rs:
##
@@ -201,14 +201,8 @@ fn test_ambiguous_reference() -> Result<()> {
let diag = do_query(query);
assert_eq
eliaperantoni commented on code in PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#discussion_r1946210717
##
datafusion/common/src/column.rs:
##
@@ -301,23 +292,6 @@ impl Column {
.flat_map(|s| s.columns())
.collect(),
}
eliaperantoni commented on code in PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#discussion_r1946209619
##
datafusion/sql/tests/cases/diagnostic.rs:
##
@@ -201,14 +201,8 @@ fn test_ambiguous_reference() -> Result<()> {
let diag = do_query(query);
asse
Lordworms commented on code in PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#discussion_r1946158176
##
datafusion/common/src/column.rs:
##
@@ -299,6 +301,23 @@ impl Column {
.flat_map(|s| s.columns())
.collect(),
})
+
eliaperantoni commented on code in PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#discussion_r1946138498
##
datafusion/common/src/column.rs:
##
@@ -299,6 +301,23 @@ impl Column {
.flat_map(|s| s.columns())
.collect(),
}
eliaperantoni commented on code in PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#discussion_r1946134872
##
datafusion/common/src/column.rs:
##
@@ -299,6 +301,23 @@ impl Column {
.flat_map(|s| s.columns())
.collect(),
}
eliaperantoni commented on code in PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#discussion_r1946134872
##
datafusion/common/src/column.rs:
##
@@ -299,6 +301,23 @@ impl Column {
.flat_map(|s| s.columns())
.collect(),
}
eliaperantoni commented on code in PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#discussion_r1946133768
##
datafusion/common/src/column.rs:
##
@@ -299,6 +301,23 @@ impl Column {
.flat_map(|s| s.columns())
.collect(),
}
eliaperantoni commented on code in PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#discussion_r1946133768
##
datafusion/common/src/column.rs:
##
@@ -299,6 +301,23 @@ impl Column {
.flat_map(|s| s.columns())
.collect(),
}
Lordworms commented on code in PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#discussion_r1946094731
##
datafusion/common/src/column.rs:
##
@@ -299,6 +301,23 @@ impl Column {
.flat_map(|s| s.columns())
.collect(),
})
+
eliaperantoni commented on code in PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#discussion_r1946069829
##
datafusion/common/src/column.rs:
##
@@ -299,6 +301,23 @@ impl Column {
.flat_map(|s| s.columns())
.collect(),
}
Lordworms commented on PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#issuecomment-2641333721
> threshold of `0.5` is reasonable. Maybe a table with multiple columns that
are increasingly further apart by eyeball (`timesamp`, `timeamp`, `timp`, `ts`,
`tokens`, `amp`, `foo`?
adriangb commented on code in PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#discussion_r1945533851
##
datafusion/sqllogictest/test_files/errors.slt:
##
@@ -161,3 +161,13 @@ create table records (timestamp timestamp, value float) as
values (
'2021-01-01 00
alamb commented on PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#issuecomment-2641075978
> It seems like these will just be part of the existing error message?
Wouldn't it make sense to integrate with the new APIs in
https://github.com/apache/datafusion/pull/13664 while we
Lordworms commented on code in PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#discussion_r1945417517
##
datafusion/sqllogictest/test_files/identifiers.slt:
##
@@ -90,16 +90,16 @@ drop table case_insensitive_test
statement ok
CREATE TABLE test("Column1" string
Lordworms commented on code in PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#discussion_r1945390440
##
datafusion/sqllogictest/test_files/errors.slt:
##
@@ -161,3 +161,13 @@ create table records (timestamp timestamp, value float) as
values (
'2021-01-01 0
comphead commented on code in PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#discussion_r1945378334
##
datafusion/sqllogictest/test_files/errors.slt:
##
@@ -161,3 +161,13 @@ create table records (timestamp timestamp, value float) as
values (
'2021-01-01 00
adriangb commented on PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#issuecomment-2640835368
Amazing work!
It seems like these will just be part of the existing error message?
Wouldn't it make sense to integrate with the new APIs in
https://github.com/apache/datafusi
alamb commented on code in PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#discussion_r1945317697
##
datafusion/sqllogictest/test_files/errors.slt:
##
@@ -161,3 +161,13 @@ create table records (timestamp timestamp, value float) as
values (
'2021-01-01 00:00
Lordworms opened a new pull request, #14521:
URL: https://github.com/apache/datafusion/pull/14521
## Which issue does this PR close?
- Closes #14466
## Rationale for this change
## What changes are included in this PR?
## Are these changes
24 matches
Mail list logo
