Lordworms commented on PR #14521: URL: https://github.com/apache/datafusion/pull/14521#issuecomment-2641333721
> threshold of `0.5` is reasonable. Maybe a table with multiple columns that are increasingly further apart by eyeball (`timesamp`, `timeamp`, `timp`, `ts`, `tokens`, `amp`, `foo`?) and see which ones get returned and which don't. > Amazing work! > > It seems like these will just be part of the existing error message? Wouldn't it make sense to integrate with the new APIs in #13664 while we're at it? I can refactor that > > I'd also suggest a test showing that a threshold of `0.5` is reasonable. Maybe a table with multiple columns that are increasingly further apart by eyeball (`timesamp`, `timeamp`, `timp`, `ts`, `tokens`, `amp`, `foo`?) and see which ones get returned and which don't. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
