alamb commented on code in PR #14521:
URL: https://github.com/apache/datafusion/pull/14521#discussion_r1945317697
##########
datafusion/sqllogictest/test_files/errors.slt:
##########
@@ -161,3 +161,13 @@ create table records (timestamp timestamp, value float) as
values (
'2021-01-01 00:00:00', 1.0,
'2021-01-01 00:00:00', 2.0
);
+
+
+statement ok
+create table a(timestamp int, birthday int);
+
+query error DataFusion error: Schema error: No field named timetamp\. Did you
mean 'a\.timestamp'\?\.
Review Comment:
nice!
##########
datafusion/sqllogictest/test_files/identifiers.slt:
##########
@@ -90,16 +90,16 @@ drop table case_insensitive_test
statement ok
CREATE TABLE test("Column1" string) AS VALUES ('content1');
-statement error DataFusion error: Schema error: No field named column1. Valid
fields are test\."Column1"\.
+statement error DataFusion error: Schema error: No field named column1\. Valid
fields are test\."Column1"\.
Review Comment:
Should't these errors also contain the nice new message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
