Re: [PR] feat: Add `array_max` function support [datafusion]

2025-03-07 Thread via GitHub
findepi merged PR #14470: URL: https://github.com/apache/datafusion/pull/14470 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafu

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-03-07 Thread via GitHub
findepi commented on PR #14470: URL: https://github.com/apache/datafusion/pull/14470#issuecomment-2706084877 Merged, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-03-03 Thread via GitHub
erenavsarogullari commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1978565612 ## datafusion/functions-nested/src/max.rs: ## @@ -0,0 +1,137 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-03-03 Thread via GitHub
erenavsarogullari commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1978565612 ## datafusion/functions-nested/src/max.rs: ## @@ -0,0 +1,137 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-03-03 Thread via GitHub
findepi commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1977038476 ## datafusion/functions-nested/src/max.rs: ## @@ -0,0 +1,137 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agre

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-03-02 Thread via GitHub
erenavsarogullari commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1976713792 ## datafusion/functions-nested/src/max.rs: ## @@ -0,0 +1,137 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-03-02 Thread via GitHub
erenavsarogullari commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1976713884 ## datafusion/sqllogictest/test_files/array.slt: ## @@ -1433,6 +1433,79 @@ NULL 23 NULL 43 5 NULL + +## array_max +# array_max scalar function #1 (wi

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-03-02 Thread via GitHub
erenavsarogullari commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1976713567 ## datafusion/functions-nested/src/max.rs: ## @@ -0,0 +1,137 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-02-11 Thread via GitHub
findepi commented on PR #14470: URL: https://github.com/apache/datafusion/pull/14470#issuecomment-2650811918 Per project guidelines proposal https://github.com/apache/datafusion/pull/13706 it feels to me as belong to core. It would be great to either finalize those guidelines or close th

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-02-10 Thread via GitHub
jayzhan211 commented on PR #14470: URL: https://github.com/apache/datafusion/pull/14470#issuecomment-2649652793 > > I have the same question for `array_min`, but if this function is highly interested from many people then adding it to datafusion core is not a bad idea. [#14417 (comment)](h

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-02-10 Thread via GitHub
findepi commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1949108541 ## datafusion/functions-nested/src/max.rs: ## @@ -0,0 +1,137 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agre

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-02-08 Thread via GitHub
erenavsarogullari commented on PR #14470: URL: https://github.com/apache/datafusion/pull/14470#issuecomment-2644719497 > I have the same question for `array_min`, but if this function is highly interested from many people then adding it to datafusion core is not a bad idea. [#14417 (commen

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-02-07 Thread via GitHub
erenavsarogullari commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1947502099 ## datafusion/functions-nested/src/max.rs: ## @@ -0,0 +1,173 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-02-07 Thread via GitHub
erenavsarogullari commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1947503074 ## datafusion/functions-nested/src/max.rs: ## @@ -0,0 +1,152 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-02-07 Thread via GitHub
erenavsarogullari commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1947502998 ## datafusion/functions-nested/src/max.rs: ## @@ -0,0 +1,152 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-02-07 Thread via GitHub
erenavsarogullari commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1947502237 ## datafusion/sqllogictest/test_files/array.slt: ## @@ -1433,6 +1433,67 @@ NULL 23 NULL 43 5 NULL + +## array_max +# array_max scalar function #1 (wi

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-02-07 Thread via GitHub
erenavsarogullari commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1947502099 ## datafusion/functions-nested/src/max.rs: ## @@ -0,0 +1,173 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-02-07 Thread via GitHub
findepi commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1946853207 ## datafusion/functions-nested/src/max.rs: ## @@ -0,0 +1,152 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agre

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-02-07 Thread via GitHub
jayzhan211 commented on PR #14470: URL: https://github.com/apache/datafusion/pull/14470#issuecomment-2642991005 I have the same question for `array_min`, but if this function is highly interested from many people then adding it to datafusion core is not a bad idea. https://github.com/apac

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-02-07 Thread via GitHub
findepi commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1946397732 ## datafusion/functions-nested/src/max.rs: ## @@ -0,0 +1,173 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agre

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-02-06 Thread via GitHub
amladik commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1945270542 ## datafusion/functions-nested/src/max.rs: ## @@ -0,0 +1,173 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agre

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-02-06 Thread via GitHub
amladik commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1945270542 ## datafusion/functions-nested/src/max.rs: ## @@ -0,0 +1,173 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agre

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-02-06 Thread via GitHub
amladik commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1945270542 ## datafusion/functions-nested/src/max.rs: ## @@ -0,0 +1,173 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agre

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-02-06 Thread via GitHub
findepi commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1944280367 ## datafusion/functions-nested/src/max.rs: ## @@ -0,0 +1,152 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agre

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-02-05 Thread via GitHub
erenavsarogullari commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1944094462 ## datafusion/functions-nested/src/max.rs: ## @@ -0,0 +1,173 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor li

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-02-05 Thread via GitHub
findepi commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1942729891 ## datafusion/functions-nested/src/max.rs: ## @@ -0,0 +1,173 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agre

Re: [PR] feat: Add `array_max` function support [datafusion]

2025-02-05 Thread via GitHub
alamb commented on PR #14470: URL: https://github.com/apache/datafusion/pull/14470#issuecomment-2636407620 FYI @findepi I think you mentioned this feature recently -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR