erenavsarogullari commented on code in PR #14470: URL: https://github.com/apache/datafusion/pull/14470#discussion_r1944094462
########## datafusion/functions-nested/src/max.rs: ########## @@ -0,0 +1,173 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +//! [`ScalarUDFImpl`] definitions for array_max function. +use crate::sort::array_sort_inner; +use crate::utils::make_scalar_function; +use arrow_array::{Array, ArrayRef, StringArray}; +use arrow_schema::DataType; +use arrow_schema::DataType::{FixedSizeList, LargeList, List}; +use datafusion_common::cast::as_list_array; +use datafusion_common::exec_err; +use datafusion_doc::Documentation; +use datafusion_expr::{ColumnarValue, Expr, ScalarUDFImpl, Signature, Volatility}; +use datafusion_macros::user_doc; +use std::any::Any; +use std::sync::Arc; + +make_udf_expr_and_func!( + ArrayMax, + array_max, + array, + "returns the maximum value in the array.", + array_max_udf +); + +#[user_doc( + doc_section(label = "Array Functions"), + description = "Returns the maximum value in the array.", + syntax_example = "array_max(array)", + sql_example = r#"```sql +> select array_max([3,1,4,2]); ++-----------------------------------------+ +| array_max(List([3,1,4,2])) | ++-----------------------------------------+ +| 4 | ++-----------------------------------------+ +```"#, + argument( + name = "array", + description = "Array expression. Can be a constant, column, or function, and any combination of array operators." + ) +)] +#[derive(Debug)] +pub struct ArrayMax { + signature: Signature, + aliases: Vec<String>, +} + +impl Default for ArrayMax { + fn default() -> Self { + Self::new() + } +} + +impl ArrayMax { + pub fn new() -> Self { + Self { + signature: Signature::array(Volatility::Immutable), + aliases: vec!["list_max".to_string()], + } + } +} + +impl ScalarUDFImpl for ArrayMax { + fn as_any(&self) -> &dyn Any { + self + } + + fn name(&self) -> &str { + "array_max" + } + + fn display_name(&self, args: &[Expr]) -> datafusion_common::Result<String> { + let args_name = args.iter().map(ToString::to_string).collect::<Vec<_>>(); + if args_name.len() != 1 { + return exec_err!("expects 1 arg, got {}", args_name.len()); + } + + Ok(format!("{}", args_name[0])) + } + + fn schema_name(&self, args: &[Expr]) -> datafusion_common::Result<String> { + let args_name = args + .iter() + .map(|e| e.schema_name().to_string()) + .collect::<Vec<_>>(); + if args_name.len() != 1 { + return exec_err!("expects 1 arg, got {}", args_name.len()); + } + + Ok(format!("{}", args_name[0])) + } Review Comment: Thanks for the review. Yes, it makes sense to use `ScalarUDFImpl` trait functions here without overriding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
