jayzhan211 commented on PR #14470: URL: https://github.com/apache/datafusion/pull/14470#issuecomment-2649652793
> > I have the same question for `array_min`, but if this function is highly interested from many people then adding it to datafusion core is not a bad idea. [#14417 (comment)](https://github.com/apache/datafusion/pull/14417#issuecomment-2642735772) > > Thanks @jayzhan211 for the review. I think we have 2 use cases for `array_min/max` functions: They need to be supported natively by DataFusion for Comet users as a clear API and abstraction and also, i think they can be useful for DF users (not using Comet) as part of core module. On the other hand, other query engines (Snowflake, Presto, GoogleSQL) also support them natively in addition to Spark. In terms of these, IMHO, they are candidate for the core module. However, it is also hard to know how much demand we will have from the community so both module options are ok for me. Sounds like Spark crate is a great place for this #5600 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
