github-actions[bot] closed pull request #15685: dynamic filter refactor
URL: https://github.com/apache/datafusion/pull/15685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
github-actions[bot] commented on PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#issuecomment-2982375299
Thank you for your contribution. Unfortunately, this pull request is stale
because it has been open 60 days with no activity. Please remove the stale
label or comment or
berkaysynnada commented on PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#issuecomment-2813385207
Blockers are gone. I think we can focus on this now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
adriangb commented on PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#issuecomment-2798502900
Hey @jayzhan211 thank you for putting the work into trying to clarify this.
At this point I think it would be best to wait for #15566 or a PR that
replaces it to be merged so
jayzhan211 commented on PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#issuecomment-2798405570
https://github.com/apache/datafusion/pull/15568#discussion_r2038773841
# why the change is equivalent to your in the high level idea.
> 1. DynamicFilterPhysicalExpr ge
jayzhan211 commented on code in PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#discussion_r2040512866
##
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##
@@ -159,35 +139,13 @@ impl DynamicFilterPhysicalExpr {
)
})?
jayzhan211 commented on code in PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#discussion_r2040512371
##
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##
@@ -159,35 +139,13 @@ impl DynamicFilterPhysicalExpr {
)
})?
jayzhan211 commented on code in PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#discussion_r2040510160
##
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##
@@ -36,16 +36,8 @@ use super::Column;
/// A dynamic [`PhysicalExpr`] that can be updated by
jayzhan211 commented on code in PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#discussion_r2040505924
##
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##
@@ -335,22 +313,12 @@ mod test {
]));
// Each ParquetExec calls `with_new_c
jayzhan211 commented on code in PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#discussion_r2040504133
##
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##
@@ -335,22 +313,12 @@ mod test {
]));
// Each ParquetExec calls `with_new_c
jayzhan211 commented on code in PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#discussion_r2040471645
##
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##
@@ -335,22 +313,12 @@ mod test {
]));
// Each ParquetExec calls `with_new_c
adriangb commented on code in PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#discussion_r2040469037
##
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##
@@ -36,16 +36,8 @@ use super::Column;
/// A dynamic [`PhysicalExpr`] that can be updated by an
adriangb commented on code in PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#discussion_r2040467822
##
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##
@@ -159,35 +139,13 @@ impl DynamicFilterPhysicalExpr {
)
})?
adriangb commented on code in PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#discussion_r2040466799
##
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##
@@ -335,22 +313,12 @@ mod test {
]));
// Each ParquetExec calls `with_new_chi
jayzhan211 commented on code in PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#discussion_r2040452282
##
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##
@@ -36,16 +36,8 @@ use super::Column;
/// A dynamic [`PhysicalExpr`] that can be updated by
jayzhan211 commented on code in PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#discussion_r2040451293
##
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##
@@ -159,35 +139,13 @@ impl DynamicFilterPhysicalExpr {
)
})?
jayzhan211 commented on code in PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#discussion_r2040450375
##
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##
@@ -335,22 +313,12 @@ mod test {
]));
// Each ParquetExec calls `with_new_c
adriangb commented on code in PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#discussion_r2039832734
##
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##
@@ -105,47 +97,44 @@ impl DynamicFilterPhysicalExpr {
inner: Arc,
) -> Self {
adriangb commented on code in PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#discussion_r2039623779
##
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##
@@ -335,22 +313,12 @@ mod test {
]));
// Each ParquetExec calls `with_new_chi
jayzhan211 opened a new pull request, #15685:
URL: https://github.com/apache/datafusion/pull/15685
## Which issue does this PR close?
- Closes #.
## Rationale for this change
## What changes are included in this PR?
## Are these changes test
20 matches
Mail list logo
