jayzhan211 commented on code in PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#discussion_r2040512866
##########
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##########
@@ -159,35 +139,13 @@ impl DynamicFilterPhysicalExpr {
)
})?
.clone();
- let inner =
- Self::remap_children(&self.children,
self.remapped_children.as_ref(), inner)?;
Review Comment:
snapshot is actually an evaluated dynamic filter based on the schema.
Basically, what you have is just the filter expression. You provide the
schema to remap the column indexes. You get yet another filter expression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
