jayzhan211 commented on code in PR #15685:
URL: https://github.com/apache/datafusion/pull/15685#discussion_r2040512371
##########
datafusion/physical-expr/src/expressions/dynamic_filters.rs:
##########
@@ -159,35 +139,13 @@ impl DynamicFilterPhysicalExpr {
)
})?
.clone();
- let inner =
- Self::remap_children(&self.children,
self.remapped_children.as_ref(), inner)?;
Review Comment:
I think the difference is that
Your version
1. we have source filter A
2. create dynamic filter a and b by different filter schema
3. you create snapshot a, b from them.
4. evaluate batches by snapshot
5. update source filter A to B
6. dynamic filter a, b remap based on source filter B when you call evaluate
My version
1. we have source filter A
2. create snapshot based on source filter A + filter schema A and B
3. evaluate batches by snapshot
4. update source filter A to B
5. create snapshot based on source filter B + filter schema A and B
6. evaluate batches by snapshot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
