alamb merged PR #14572:
URL: https://github.com/apache/datafusion/pull/14572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#issuecomment-2662902791
🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
zhuqi-lucas commented on PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#issuecomment-2660925053
> This looks like an improvment to me -- thank you @zhuqi-lucas and @jonahgao
Thanks @alamb for review, addressed in latest PR. For union schema potential
schema checking i
zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1957117043
##
datafusion/core/tests/dataframe/mod.rs:
##
@@ -5274,3 +5274,61 @@ async fn register_non_parquet_file() {
"1.json' does not match the expected exten
zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1957116873
##
datafusion/core/tests/dataframe/mod.rs:
##
@@ -5274,3 +5274,61 @@ async fn register_non_parquet_file() {
"1.json' does not match the expected exten
zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1957116717
##
datafusion/common/src/dfschema.rs:
##
@@ -1028,21 +1028,32 @@ impl SchemaExt for Schema {
})
}
-fn logically_equivalent_names_and_ty
alamb commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1957090671
##
datafusion/core/tests/dataframe/mod.rs:
##
@@ -5274,3 +5274,61 @@ async fn register_non_parquet_file() {
"1.json' does not match the expected extension '
zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1954754897
##
datafusion/common/src/dfschema.rs:
##
@@ -1028,21 +1028,32 @@ impl SchemaExt for Schema {
})
}
-fn logically_equivalent_names_and_ty
zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1954746359
##
datafusion/common/src/dfschema.rs:
##
@@ -1028,21 +1028,41 @@ impl SchemaExt for Schema {
})
}
-fn logically_equivalent_names_and_ty
zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1954710305
##
datafusion/common/src/dfschema.rs:
##
@@ -1028,21 +1028,41 @@ impl SchemaExt for Schema {
})
}
-fn logically_equivalent_names_and_ty
jonahgao commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1954616404
##
datafusion/sqllogictest/test_files/insert_to_external.slt:
##
@@ -60,17 +60,16 @@ STORED AS parquet
LOCATION 'test_files/scratch/insert_to_external/parquet_ty
jonahgao commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1954600078
##
datafusion/common/src/dfschema.rs:
##
@@ -1028,21 +1028,32 @@ impl SchemaExt for Schema {
})
}
-fn logically_equivalent_names_and_types
jonahgao commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1954592060
##
datafusion/common/src/dfschema.rs:
##
@@ -1028,21 +1028,41 @@ impl SchemaExt for Schema {
})
}
-fn logically_equivalent_names_and_types
jonahgao commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1954582396
##
datafusion/common/src/dfschema.rs:
##
@@ -1028,21 +1028,41 @@ impl SchemaExt for Schema {
})
}
-fn logically_equivalent_names_and_types
zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1953772428
##
datafusion/common/src/dfschema.rs:
##
@@ -1028,21 +1028,41 @@ impl SchemaExt for Schema {
})
}
-fn logically_equivalent_names_and_ty
zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1952860229
##
datafusion/common/src/dfschema.rs:
##
@@ -1028,21 +1028,41 @@ impl SchemaExt for Schema {
})
}
-fn logically_equivalent_names_and_ty
jonahgao commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1952677078
##
datafusion/common/src/dfschema.rs:
##
@@ -1028,21 +1028,41 @@ impl SchemaExt for Schema {
})
}
-fn logically_equivalent_names_and_types
zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1952513001
##
datafusion/sqllogictest/test_files/insert_to_external.slt:
##
@@ -60,17 +60,16 @@ STORED AS parquet
LOCATION 'test_files/scratch/insert_to_external/parquet
zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1952620730
##
datafusion/sqllogictest/test_files/insert_to_external.slt:
##
@@ -60,17 +60,16 @@ STORED AS parquet
LOCATION 'test_files/scratch/insert_to_external/parquet
zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1952620730
##
datafusion/sqllogictest/test_files/insert_to_external.slt:
##
@@ -60,17 +60,16 @@ STORED AS parquet
LOCATION 'test_files/scratch/insert_to_external/parquet
zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1952620730
##
datafusion/sqllogictest/test_files/insert_to_external.slt:
##
@@ -60,17 +60,16 @@ STORED AS parquet
LOCATION 'test_files/scratch/insert_to_external/parquet
zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1952513001
##
datafusion/sqllogictest/test_files/insert_to_external.slt:
##
@@ -60,17 +60,16 @@ STORED AS parquet
LOCATION 'test_files/scratch/insert_to_external/parquet
jayzhan211 commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1952544758
##
datafusion/sqllogictest/test_files/insert_to_external.slt:
##
@@ -60,17 +60,16 @@ STORED AS parquet
LOCATION 'test_files/scratch/insert_to_external/parquet_
jayzhan211 commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1952543911
##
datafusion/sqllogictest/test_files/insert_to_external.slt:
##
@@ -60,17 +60,16 @@ STORED AS parquet
LOCATION 'test_files/scratch/insert_to_external/parquet_
jayzhan211 commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1952422238
##
datafusion/sqllogictest/test_files/insert_to_external.slt:
##
@@ -60,17 +60,16 @@ STORED AS parquet
LOCATION 'test_files/scratch/insert_to_external/parquet_
zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1952352719
##
datafusion/sqllogictest/test_files/insert_to_external.slt:
##
@@ -60,17 +60,16 @@ STORED AS parquet
LOCATION 'test_files/scratch/insert_to_external/parquet
zhuqi-lucas commented on PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#issuecomment-2653205051
The CI error is caused by:
https://github.com/apache/datafusion/pull/14625
--
This is an automated message from the Apache Git Service.
To respond to the message, please
zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1952317116
##
datafusion/sqllogictest/test_files/insert.slt:
##
@@ -296,8 +296,11 @@ insert into table_without_values(field1) values(3);
1
# insert NULL values for th
zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1952299587
##
datafusion/common/src/dfschema.rs:
##
@@ -1028,20 +1028,48 @@ impl SchemaExt for Schema {
})
}
-fn logically_equivalent_names_and_ty
jayzhan211 commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1951940530
##
datafusion/common/src/dfschema.rs:
##
@@ -1028,20 +1028,48 @@ impl SchemaExt for Schema {
})
}
-fn logically_equivalent_names_and_typ
zhuqi-lucas commented on PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#issuecomment-2652596170
> Can you explain the reason of the change in test.slt, thanks
Thank you for review @jayzhan211, i already updated the slt now, and added
note for the only 2 different resu
31 matches
Mail list logo
