zhuqi-lucas commented on code in PR #14572:
URL: https://github.com/apache/datafusion/pull/14572#discussion_r1952620730


##########
datafusion/sqllogictest/test_files/insert_to_external.slt:
##########
@@ -60,17 +60,16 @@ STORED AS parquet
 LOCATION 'test_files/scratch/insert_to_external/parquet_types_partitioned/'
 PARTITIONED BY (b);
 
-query I
+query error
 insert into dictionary_encoded_parquet_partitioned
 select * from dictionary_encoded_values
 ----
-2
+DataFusion error: Error during planning: Inserting query must have the same 
schema nullability as the table. Expected table field 'b' nullability: false, 
got field: 'b', nullability: true

Review Comment:
   @jayzhan211  This 
https://github.com/apache/datafusion/pull/14439/files#diff-51757b2b1d0a07b88551d88eabeba7f74e11b5217e44203ac7c6f613c0221196R273
 merged less than a week ago. I think it's start from there, and i tried local 
sql logic test use -- --complete, it's also the same result, i guess the CI 
also use it to generate and verify?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to