jayzhan211 commented on code in PR #14572: URL: https://github.com/apache/datafusion/pull/14572#discussion_r1952422238
########## datafusion/sqllogictest/test_files/insert_to_external.slt: ########## @@ -60,17 +60,16 @@ STORED AS parquet LOCATION 'test_files/scratch/insert_to_external/parquet_types_partitioned/' PARTITIONED BY (b); -query I +query error insert into dictionary_encoded_parquet_partitioned select * from dictionary_encoded_values ---- -2 +DataFusion error: Error during planning: Inserting query must have the same schema nullability as the table. Expected table field 'b' nullability: false, got field: 'b', nullability: true Review Comment: Error should be after `query error` to pass CI ########## datafusion/sqllogictest/test_files/insert_to_external.slt: ########## @@ -60,17 +60,16 @@ STORED AS parquet LOCATION 'test_files/scratch/insert_to_external/parquet_types_partitioned/' PARTITIONED BY (b); -query I +query error insert into dictionary_encoded_parquet_partitioned select * from dictionary_encoded_values ---- -2 +DataFusion error: Error during planning: Inserting query must have the same schema nullability as the table. Expected table field 'b' nullability: false, got field: 'b', nullability: true Review Comment: `because PARTITIONED BY (b), will make the b nullable to false` can be add as comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
