tobixdev closed pull request #14617: WIP: Add LogicalScalar
URL: https://github.com/apache/datafusion/pull/14617
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
tobixdev commented on PR #14617:
URL: https://github.com/apache/datafusion/pull/14617#issuecomment-2664903880
Closing this PR for now
See https://github.com/apache/datafusion/issues/12622#issuecomment-2664902018
--
This is an automated message from the Apache Git Service.
To respond to
tobixdev commented on code in PR #14617:
URL: https://github.com/apache/datafusion/pull/14617#discussion_r1957922037
##
datafusion/common/src/scalar/logical/mod.rs:
##
@@ -0,0 +1,400 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licens
tobixdev commented on code in PR #14617:
URL: https://github.com/apache/datafusion/pull/14617#discussion_r1957926257
##
datafusion/sql/src/unparser/expr.rs:
##
@@ -1831,15 +1625,15 @@ mod tests {
),
(
Expr::Literal(ScalarValue::Date64(S
jayzhan211 commented on code in PR #14617:
URL: https://github.com/apache/datafusion/pull/14617#discussion_r1952808036
##
datafusion/common/src/scalar/logical/mod.rs:
##
@@ -0,0 +1,400 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lice
tobixdev commented on code in PR #14617:
URL: https://github.com/apache/datafusion/pull/14617#discussion_r1951951528
##
datafusion/common/src/scalar/logical/logical_timestamp.rs:
##
@@ -0,0 +1,141 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more cont
tobixdev commented on code in PR #14617:
URL: https://github.com/apache/datafusion/pull/14617#discussion_r1951952949
##
datafusion/common/src/scalar/logical/mod.rs:
##
@@ -0,0 +1,400 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor licens
jayzhan211 commented on code in PR #14617:
URL: https://github.com/apache/datafusion/pull/14617#discussion_r1951861002
##
datafusion/common/src/scalar/logical/logical_timestamp.rs:
##
@@ -0,0 +1,141 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more co
jayzhan211 commented on code in PR #14617:
URL: https://github.com/apache/datafusion/pull/14617#discussion_r1951858302
##
datafusion/common/src/scalar/logical/logical_fixed_size_list.rs:
##
@@ -0,0 +1,75 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or mo
jayzhan211 commented on code in PR #14617:
URL: https://github.com/apache/datafusion/pull/14617#discussion_r1951856696
##
datafusion/common/src/scalar/logical/mod.rs:
##
@@ -0,0 +1,400 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor lice
jayzhan211 commented on code in PR #14617:
URL: https://github.com/apache/datafusion/pull/14617#discussion_r1951855360
##
datafusion/common/src/scalar/logical/logical_date.rs:
##
@@ -0,0 +1,55 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contribu
jayzhan211 commented on PR #14617:
URL: https://github.com/apache/datafusion/pull/14617#issuecomment-2652433864
For decimal, I think it should be the same as ScalarValue given we need to
differentiate the precision of it
```
Decimal128(Option, u8, i8),
Decimal256(Option,
jayzhan211 commented on PR #14617:
URL: https://github.com/apache/datafusion/pull/14617#issuecomment-2652407861
> However, as this breaks quite a few things, doing this will be done in
other PRs (I think https://github.com/apache/datafusion/pull/14609 is exploring
this impact)
I hope
jayzhan211 commented on code in PR #14617:
URL: https://github.com/apache/datafusion/pull/14617#discussion_r1951823533
##
datafusion/sql/src/unparser/expr.rs:
##
@@ -1831,15 +1625,15 @@ mod tests {
),
(
Expr::Literal(ScalarValue::Date64
tobixdev commented on code in PR #14617:
URL: https://github.com/apache/datafusion/pull/14617#discussion_r1951589583
##
datafusion/common/src/types/builtin.rs:
##
@@ -47,3 +50,53 @@ singleton!(LOGICAL_FLOAT64, logical_float64, Float64);
singleton!(LOGICAL_DATE, logical_date, Da
tobixdev commented on code in PR #14617:
URL: https://github.com/apache/datafusion/pull/14617#discussion_r1951588187
##
datafusion/sql/src/unparser/expr.rs:
##
@@ -1831,15 +1625,15 @@ mod tests {
),
(
Expr::Literal(ScalarValue::Date64(S
tobixdev opened a new pull request, #14617:
URL: https://github.com/apache/datafusion/pull/14617
## Which issue does this PR close?
This change is related to #12622.
While the PR is not yet complete, I won't be able to work on it for at least
a few days. Therefore, I'd like to
17 matches
Mail list logo
