tobixdev commented on code in PR #14617:
URL: https://github.com/apache/datafusion/pull/14617#discussion_r1957926257
##########
datafusion/sql/src/unparser/expr.rs:
##########
@@ -1831,15 +1625,15 @@ mod tests {
),
(
Expr::Literal(ScalarValue::Date64(Some(0))),
- r#"CAST('1970-01-01 00:00:00' AS DATETIME)"#,
+ r#"CAST('1970-01-01 00:00:00' AS TIMESTAMP)"#,
Review Comment:
Ok then we would need to separate `Date32` and `Date64` which you mentioned
in another comment. I only have `Date32` in this PR as there is only
`NativeType::Date` which mentions the definition of `Date32`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
