tobixdev commented on code in PR #14617: URL: https://github.com/apache/datafusion/pull/14617#discussion_r1951589583
########## datafusion/common/src/types/builtin.rs: ########## @@ -47,3 +50,53 @@ singleton!(LOGICAL_FLOAT64, logical_float64, Float64); singleton!(LOGICAL_DATE, logical_date, Date); singleton!(LOGICAL_BINARY, logical_binary, Binary); singleton!(LOGICAL_STRING, logical_string, String); + +pub fn logical_timestamp( Review Comment: Some interning or similar could be beneficial here to share `Arc`s between invocations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
