iffyio merged PR #1757:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
MohamedAbdeen21 commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1992146128
##
src/ast/mod.rs:
##
@@ -6148,12 +6218,12 @@ impl fmt::Display for GrantObjects {
#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash
iffyio commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1992136840
##
src/ast/mod.rs:
##
@@ -6148,12 +6218,12 @@ impl fmt::Display for GrantObjects {
#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
#[cfg
iffyio commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1990706375
##
src/parser/mod.rs:
##
@@ -10955,134 +10955,226 @@ impl<'a> Parser<'a> {
} else {
Some(self.parse_identifier()?)
};
-
MohamedAbdeen21 commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1989928177
##
src/parser/mod.rs:
##
@@ -10955,134 +10955,226 @@ impl<'a> Parser<'a> {
} else {
Some(self.parse_identifier()?)
iffyio commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1988400540
##
src/ast/mod.rs:
##
@@ -6148,12 +6218,12 @@ impl fmt::Display for GrantObjects {
#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash)]
#[cfg
mvzink commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1984139573
##
tests/sqlparser_common.rs:
##
@@ -14654,3 +14640,23 @@ fn parse_set_names() {
dialects.verified_stmt("SET NAMES 'utf8'");
dialects.verified
MohamedAbdeen21 commented on PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#issuecomment-2711805999
Ended up being a big one.
API changes:
1. New struct `SetAssignment` instead of using the tuple `(ObjectName,
Expr)` suggested above because visitor feat
MohamedAbdeen21 commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1989297099
##
src/ast/mod.rs:
##
@@ -6148,12 +6218,12 @@ impl fmt::Display for GrantObjects {
#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash
MohamedAbdeen21 commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1988715933
##
src/parser/mod.rs:
##
@@ -10955,134 +10955,226 @@ impl<'a> Parser<'a> {
} else {
Some(self.parse_identifier()?)
MohamedAbdeen21 commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1988719022
##
src/parser/mod.rs:
##
@@ -10955,134 +10955,226 @@ impl<'a> Parser<'a> {
} else {
Some(self.parse_identifier()?)
MohamedAbdeen21 commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1988708402
##
src/ast/mod.rs:
##
@@ -6148,12 +6218,12 @@ impl fmt::Display for GrantObjects {
#[derive(Debug, Clone, PartialEq, PartialOrd, Eq, Ord, Hash
MohamedAbdeen21 commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1986585508
##
src/ast/mod.rs:
##
@@ -2947,6 +2947,17 @@ pub enum Statement {
variables: OneOrManyWithParens,
value: Vec,
},
+
+
iffyio commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1986233456
##
src/ast/mod.rs:
##
@@ -2947,6 +2947,17 @@ pub enum Statement {
variables: OneOrManyWithParens,
value: Vec,
},
+
+/// ```sq
mvzink commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1986222154
##
src/ast/mod.rs:
##
@@ -2947,6 +2947,17 @@ pub enum Statement {
variables: OneOrManyWithParens,
value: Vec,
},
+
+/// ```sq
mvzink commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1986222154
##
src/ast/mod.rs:
##
@@ -2947,6 +2947,17 @@ pub enum Statement {
variables: OneOrManyWithParens,
value: Vec,
},
+
+/// ```sq
iffyio commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1986001377
##
src/ast/mod.rs:
##
@@ -2947,6 +2947,17 @@ pub enum Statement {
variables: OneOrManyWithParens,
value: Vec,
},
+
+/// ```sq
mvzink commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1985755405
##
src/ast/mod.rs:
##
@@ -5334,6 +5345,16 @@ impl fmt::Display for Statement {
Statement::List(command) => write!(f, "LIST {command}"),
MohamedAbdeen21 commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1985708864
##
src/dialect/mysql.rs:
##
@@ -141,6 +141,10 @@ impl Dialect for MySqlDialect {
fn supports_set_names(&self) -> bool {
true
mvzink commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1985643698
##
src/parser/mod.rs:
##
@@ -10961,127 +10961,182 @@ impl<'a> Parser<'a> {
})
}
-pub fn parse_set(&mut self) -> Result {
-le
mvzink commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1985631206
##
src/parser/mod.rs:
##
@@ -10961,127 +10961,182 @@ impl<'a> Parser<'a> {
})
}
-pub fn parse_set(&mut self) -> Result {
-le
MohamedAbdeen21 commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1985615457
##
src/parser/mod.rs:
##
@@ -10961,127 +10961,182 @@ impl<'a> Parser<'a> {
})
}
-pub fn parse_set(&mut self) -> Result {
-
MohamedAbdeen21 commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1985619929
##
src/parser/mod.rs:
##
@@ -10961,127 +10961,184 @@ impl<'a> Parser<'a> {
})
}
-pub fn parse_set(&mut self) -> Result {
-
MohamedAbdeen21 commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1985608039
##
tests/sqlparser_common.rs:
##
@@ -14654,3 +14640,23 @@ fn parse_set_names() {
dialects.verified_stmt("SET NAMES 'utf8'");
dialects
MohamedAbdeen21 commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1985605486
##
src/parser/mod.rs:
##
@@ -10961,127 +10961,184 @@ impl<'a> Parser<'a> {
})
}
-pub fn parse_set(&mut self) -> Result {
-
MohamedAbdeen21 commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1985567283
##
src/dialect/mysql.rs:
##
@@ -141,6 +141,10 @@ impl Dialect for MySqlDialect {
fn supports_set_names(&self) -> bool {
true
MohamedAbdeen21 commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1985543609
##
src/parser/mod.rs:
##
@@ -10961,127 +10961,182 @@ impl<'a> Parser<'a> {
})
}
-pub fn parse_set(&mut self) -> Result {
-
iffyio commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1984492397
##
src/parser/mod.rs:
##
@@ -10961,127 +10961,182 @@ impl<'a> Parser<'a> {
})
}
-pub fn parse_set(&mut self) -> Result {
-le
28 matches
Mail list logo
