MohamedAbdeen21 commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1985567283
##########
src/dialect/mysql.rs:
##########
@@ -141,6 +141,10 @@ impl Dialect for MySqlDialect {
fn supports_set_names(&self) -> bool {
true
}
+
+ fn supports_comma_separated_set_assignments(&self) -> bool {
+ true
Review Comment:
That will cause some tests to fail. A dialect should either allow snowflake
syntax or MySQL syntax.
For comma-separated lists, values are parsed using the `parse_expr` parser,
which stops at commas.
For all other `SET` statements, we use a loop (extracted to a func called
`parse_set_values` in this PR) that collects all comma-separated tokens as
`Vec<value>`, because some dialects allow that (MSSQL and Hive for example).
And by the way, that's what caused the output reported in the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
