MohamedAbdeen21 commented on code in PR #1757:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1757#discussion_r1985608039
##########
tests/sqlparser_common.rs:
##########
@@ -14654,3 +14640,23 @@ fn parse_set_names() {
dialects.verified_stmt("SET NAMES 'utf8'");
dialects.verified_stmt("SET NAMES UTF8 COLLATE bogus");
}
+
+#[test]
+fn parse_multiple_set_statements() -> Result<(), ParserError> {
+ let dialects = all_dialects_where(|d|
d.supports_comma_separated_set_assignments());
+ let stmt = dialects.parse_sql_statements("SET @a = 1, b = 2")?;
Review Comment:
You're other comment is correct; it gets translated to snowflake-style.
Either update the enum/variants to reflect the syntax used or use
`dialects.one_statement_parses_to("SET @a = 1, b = 2", "SET (@a, b) = (1, 2)");`
##########
tests/sqlparser_common.rs:
##########
@@ -14654,3 +14640,23 @@ fn parse_set_names() {
dialects.verified_stmt("SET NAMES 'utf8'");
dialects.verified_stmt("SET NAMES UTF8 COLLATE bogus");
}
+
+#[test]
+fn parse_multiple_set_statements() -> Result<(), ParserError> {
+ let dialects = all_dialects_where(|d|
d.supports_comma_separated_set_assignments());
+ let stmt = dialects.parse_sql_statements("SET @a = 1, b = 2")?;
Review Comment:
Your other comment is correct; it gets translated to snowflake-style. Either
update the enum/variants to reflect the syntax used or use
`dialects.one_statement_parses_to("SET @a = 1, b = 2", "SET (@a, b) = (1, 2)");`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
