alamb commented on PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#issuecomment-2740798896
> I will port the tests on our next iteration, but would appreciate a
recommendation for a good suite to add them to as I rewrite them - they are
currently only validating the `InlineT
alamb commented on PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#issuecomment-2738300722
@aditanase perhaps you can make a PR with whatever tests were breaking in
your fork so we can make sure they work here
--
This is an automated message from the Apache Git Service.
T
aditanase commented on PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#issuecomment-2739305725
The fork was not compiling, we were on 46.0.0 but the latest changes made my
rebase more difficult than usual, we'll figure it out.
I will port the tests on our next iteratio
jayzhan211 commented on PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#issuecomment-2736677639
@aditanase
It works too
```
statement count 0
create table t(a int) as values (1), (2), (3);
statement count 0
create view v as select a, count(a) fro
aditanase commented on PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#issuecomment-273664
@jayzhan211 can you try with a 3rd view? 2 levels were also working on the
original inlining code.
Here you only need to inline v inside v2 and you get the final plan.
if you
jayzhan211 commented on PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#issuecomment-2736240081
```
statement count 0
create table t(a int) as values (1), (2), (3);
statement count 0
create view v as select a, count(a) from t group by a;
query II rowsort
aditanase commented on PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#issuecomment-2736011205
Hi @jayzhan211 @alamb, I'm a bit concerned with this patch, I was just in
the process of submitting an enhancement to `InlineTableScan` that was dealing
with multiple levels of vie
jayzhan211 merged PR #15201:
URL: https://github.com/apache/datafusion/pull/15201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@dat
jayzhan211 commented on PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#issuecomment-2734924833
Thanks @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
jayzhan211 commented on code in PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#discussion_r2000904176
##
datafusion/core/tests/dataframe/mod.rs:
##
@@ -1571,14 +1571,18 @@ async fn with_column_join_same_columns() -> Result<()> {
assert_snapshot!(
alamb commented on code in PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#discussion_r1995496219
##
datafusion/sqllogictest/test_files/ddl.slt:
##
@@ -855,3 +855,29 @@ DROP TABLE t1;
statement ok
DROP TABLE t2;
+
+statement count 0
+create table t(a int) as
jayzhan211 commented on code in PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#discussion_r1996487546
##
datafusion/core/tests/dataframe/mod.rs:
##
@@ -1563,8 +1563,12 @@ async fn with_column_join_same_columns() -> Result<()> {
\n Limit: skip=0, fetch=
alamb commented on code in PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#discussion_r1996808102
##
datafusion/core/tests/dataframe/mod.rs:
##
@@ -1571,14 +1571,18 @@ async fn with_column_join_same_columns() -> Result<()> {
assert_snapshot!(
df_w
jayzhan211 commented on code in PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#discussion_r1996487546
##
datafusion/core/tests/dataframe/mod.rs:
##
@@ -1563,8 +1563,12 @@ async fn with_column_join_same_columns() -> Result<()> {
\n Limit: skip=0, fetch=
jayzhan211 commented on code in PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#discussion_r1996463077
##
datafusion/core/tests/dataframe/mod.rs:
##
@@ -1563,8 +1563,12 @@ async fn with_column_join_same_columns() -> Result<()> {
\n Limit: skip=0, fetch=
alamb commented on PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#issuecomment-2725551994
I ran planning performance benchmarks and I would say they showed no
discernible difference with this branch
Details
```
group
jayzhan211 commented on code in PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#discussion_r1994540603
##
datafusion/sql/src/select.rs:
##
@@ -550,7 +550,29 @@ impl SqlToRel<'_, S> {
0 => Ok(LogicalPlanBuilder::empty(true).build()?),
1 =
alamb commented on code in PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#discussion_r1993384623
##
datafusion/sql/src/select.rs:
##
@@ -550,7 +550,29 @@ impl SqlToRel<'_, S> {
0 => Ok(LogicalPlanBuilder::empty(true).build()?),
1 => {
jayzhan211 opened a new pull request, #15201:
URL: https://github.com/apache/datafusion/pull/15201
## Which issue does this PR close?
- Part of #14618
## Rationale for this change
## What changes are included in this PR?
## Are these change
19 matches
Mail list logo
