alamb commented on code in PR #15201: URL: https://github.com/apache/datafusion/pull/15201#discussion_r1993384623
########## datafusion/sql/src/select.rs: ########## @@ -550,7 +550,29 @@ impl<S: ContextProvider> SqlToRel<'_, S> { 0 => Ok(LogicalPlanBuilder::empty(true).build()?), 1 => { let input = from.remove(0); - self.plan_table_with_joins(input, planner_context) + let table = self.plan_table_with_joins(input, planner_context)?; Review Comment: This will have the effect of only inlining table scans for SQL Perhaps we could move the code into LogicalPlanBuilder so it also applies to dataframes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org