jayzhan211 commented on code in PR #15201:
URL: https://github.com/apache/datafusion/pull/15201#discussion_r1996487546


##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -1563,8 +1563,12 @@ async fn with_column_join_same_columns() -> Result<()> {
         \n  Limit: skip=0, fetch=1\
         \n    Sort: t1.c1 ASC NULLS FIRST\
         \n      Inner Join: t1.c1 = t2.c1\
-        \n        TableScan: t1\
-        \n        TableScan: t2",
+        \n        SubqueryAlias: t1\

Review Comment:
   You can check the `into_optimized_plan` below, we have the consistent result.
   
   The process includes both an analyzer and an optimizer. This is why the main 
branch does not contain a subquery before optimization, but one appears after 
inline_tablescan is called.
   
   In this change, since inline_tablescan is invoked during plan building, the 
subquery is introduced before the optimization step



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to