qstommyshu commented on code in PR #15548:
URL: https://github.com/apache/datafusion/pull/15548#discussion_r2025673832
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -2928,37 +3062,74 @@ fn select_groupby_orderby() {
date_trunc('month', birth_date) AS "birth_date"
FROM
qstommyshu opened a new pull request, #15548:
URL: https://github.com/apache/datafusion/pull/15548
## Which issue does this PR close?
- Related #15484, #15397, #15497, #15499, #15533
- this is a part of #15484 breaking down.
- Checkout things to note of the whole migrati
qstommyshu commented on PR #15548:
URL: https://github.com/apache/datafusion/pull/15548#issuecomment-2773754969
This PR does only one thing:
Migrate part of the tests done with quick_test() to insta (This is the last
PR on migrating `quick_test()`, the next one would be migration on
qstommyshu commented on code in PR #15548:
URL: https://github.com/apache/datafusion/pull/15548#discussion_r2027111797
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -1766,41 +1767,56 @@ fn
select_simple_aggregate_with_groupby_non_column_expression_and_its_column_sel
#[te
blaginin commented on code in PR #15548:
URL: https://github.com/apache/datafusion/pull/15548#discussion_r2026909887
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -77,9 +77,8 @@ fn parse_decimals() {
for (a, b) in test_data {
let sql = format!("SELECT {a}");
alamb commented on PR #15548:
URL: https://github.com/apache/datafusion/pull/15548#issuecomment-2776376489
Thanks again! This is looking really nice now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
alamb merged PR #15548:
URL: https://github.com/apache/datafusion/pull/15548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
qstommyshu commented on PR #15548:
URL: https://github.com/apache/datafusion/pull/15548#issuecomment-2776033537
I also replaced `generate_logical_plan()` to `logical_plan().unwrap()` as
the function `logical_plan()` already existed before the migration. The
`generate_logical_plan()` I creat
qstommyshu commented on PR #15548:
URL: https://github.com/apache/datafusion/pull/15548#issuecomment-2775959816
I also broke the giant series of `assert_snapshot!` in `parse_decimals()`
into multiple tests, I think it is better to have multiple small and
descriptive tests instead of a giant
qstommyshu commented on code in PR #15548:
URL: https://github.com/apache/datafusion/pull/15548#discussion_r2027104977
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -77,9 +77,8 @@ fn parse_decimals() {
for (a, b) in test_data {
let sql = format!("SELECT {a}");
qstommyshu commented on code in PR #15548:
URL: https://github.com/apache/datafusion/pull/15548#discussion_r2025673999
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -4786,30 +4972,47 @@ fn test_field_not_found_window_function() {
"###
);
-let qualified_sq
blaginin commented on code in PR #15548:
URL: https://github.com/apache/datafusion/pull/15548#discussion_r2025642263
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -2928,37 +3062,74 @@ fn select_groupby_orderby() {
date_trunc('month', birth_date) AS "birth_date"
FROM pe
qstommyshu commented on code in PR #15548:
URL: https://github.com/apache/datafusion/pull/15548#discussion_r2025629769
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -4786,30 +4972,47 @@ fn test_field_not_found_window_function() {
"###
);
-let qualified_sq
blaginin commented on code in PR #15548:
URL: https://github.com/apache/datafusion/pull/15548#discussion_r2025624199
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -4786,30 +4972,47 @@ fn test_field_not_found_window_function() {
"###
);
-let qualified_sql
blaginin commented on code in PR #15548:
URL: https://github.com/apache/datafusion/pull/15548#discussion_r2025616184
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -1766,41 +1766,57 @@ fn
select_simple_aggregate_with_groupby_non_column_expression_and_its_column_sel
#[test
blaginin commented on code in PR #15548:
URL: https://github.com/apache/datafusion/pull/15548#discussion_r2025614479
##
datafusion/sql/tests/sql_integration.rs:
##
@@ -1766,41 +1766,57 @@ fn
select_simple_aggregate_with_groupby_non_column_expression_and_its_column_sel
#[test
16 matches
Mail list logo
