blaginin commented on code in PR #15548:
URL: https://github.com/apache/datafusion/pull/15548#discussion_r2026909887
##########
datafusion/sql/tests/sql_integration.rs:
##########
@@ -77,9 +77,8 @@ fn parse_decimals() {
for (a, b) in test_data {
let sql = format!("SELECT {a}");
let expected = format!("Projection: {b}\n EmptyRelation");
- quick_test_with_options(
+ let plan = logical_plan_with_options(
&sql,
- &expected,
Review Comment:
i think there's a way to use insta here too: define `ParserOptions` once and
then just rewrite as a list of asserts (instead of the for loop). That way,
we'll be able to update expected values easily
##########
datafusion/sql/tests/sql_integration.rs:
##########
@@ -1766,41 +1767,56 @@ fn
select_simple_aggregate_with_groupby_non_column_expression_and_its_column_sel
#[test]
fn select_simple_aggregate_nested_in_binary_expr_with_groupby() {
- quick_test(
- "SELECT state, MIN(age) < 10 FROM person GROUP BY state",
- "Projection: person.state, min(person.age) < Int64(10)\
- \n Aggregate: groupBy=[[person.state]], aggr=[[min(person.age)]]\
- \n TableScan: person",
+ let plan =
+ generate_logical_plan("SELECT state, MIN(age) + 1 FROM person GROUP BY
state");
Review Comment:
There's a different query from the previous one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
