qstommyshu commented on PR #15548: URL: https://github.com/apache/datafusion/pull/15548#issuecomment-2775959816
I also broke the giant series of `assert_snapshot!` in `parse_decimals()` into multiple tests, I think it is better to have multiple small and descriptive tests instead of a giant one. That way when a developer found a bug, they can quickly identify which test case went wrong, not spending extra time to figure out which assertion failed in a giant test. Same thing applied for test `parse_ident_normalization()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
