alamb merged PR #14520:
URL: https://github.com/apache/datafusion/pull/14520
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
davisp commented on PR #14520:
URL: https://github.com/apache/datafusion/pull/14520#issuecomment-2640559128
@alamb Thanks for the tip! I've moved the test to the macro_hygiene module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
alamb commented on code in PR #14520:
URL: https://github.com/apache/datafusion/pull/14520#discussion_r1943799473
##
datafusion/common/src/config.rs:
##
@@ -2093,3 +2094,22 @@ mod tests {
assert_eq!(parsed_metadata.get("key_dupe"), Some(&Some("B".into(;
}
}
+
rkrishn7 commented on code in PR #14520:
URL: https://github.com/apache/datafusion/pull/14520#discussion_r1943795899
##
datafusion/common/src/config.rs:
##
@@ -2093,3 +2094,22 @@ mod tests {
assert_eq!(parsed_metadata.get("key_dupe"), Some(&Some("B".into(;
}
}
davisp opened a new pull request, #14520:
URL: https://github.com/apache/datafusion/pull/14520
The `config_namespace` macro was relying on a few symbols being properly
imported before its used. This removes that need by referring to the symbols
directly with the `$crate` prefix.
## W
