rkrishn7 commented on code in PR #14520:
URL: https://github.com/apache/datafusion/pull/14520#discussion_r1943795899
##########
datafusion/common/src/config.rs:
##########
@@ -2093,3 +2094,22 @@ mod tests {
assert_eq!(parsed_metadata.get("key_dupe"), Some(&Some("B".into())));
}
}
+
+#[cfg(test)]
+mod tests_isolated {
+ // The point of this test is to check that the config_namespace! macro
+ // can compile without any surrounding `use` statements. Hence putting
+ // it into its own test module.
+ #[test]
+ fn check_config_namespace_macro() {
Review Comment:
Do you think it may be better to add this test/module in `lib.rs` 🤔 ?
Since the subtle addition of a `use super::*` in the future would
effectively hide any regression here.
##########
datafusion/common/src/config.rs:
##########
@@ -2093,3 +2094,22 @@ mod tests {
assert_eq!(parsed_metadata.get("key_dupe"), Some(&Some("B".into())));
}
}
+
+#[cfg(test)]
+mod tests_isolated {
Review Comment:
```suggestion
mod tests {
```
I think it may be best to stick to
[convention](https://doc.rust-lang.org/book/ch11-03-test-organization.html#unit-tests)
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
