davisp opened a new pull request, #14520:
URL: https://github.com/apache/datafusion/pull/14520

   The `config_namespace` macro was relying on a few symbols being properly 
imported before its used. This removes that need by referring to the symbols 
directly with the `$crate` prefix.
   
   ## Which issue does this PR close?
   
   - Closes #14518.
   
   ## Rationale for this change
   
   The `config_namespace!` macro relied on symbols being properly imported. 
This fixes that issue.
   
   ## What changes are included in this PR?
   
   1. Fix `config_namespace!` to not require imported symbols being available.
   2. Re-add the inadvertently removed `#[macro_export]` attribute.
   
   ## Are these changes tested?
   
   Yes. There's an isolated test to show that the macro now works without any 
`use` statements.
   
   ## Are there any user-facing changes?
   
   Some folks might get "unused import" diagnostics/warnings after this change, 
maybe?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to