gabotechs commented on PR #15794:
URL: https://github.com/apache/datafusion/pull/15794#issuecomment-2889824953
Follow up for the producer part:
https://github.com/apache/datafusion/pull/16089
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
alamb merged PR #15794:
URL: https://github.com/apache/datafusion/pull/15794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
alamb commented on PR #15794:
URL: https://github.com/apache/datafusion/pull/15794#issuecomment-2845786048
Thanks again @vbarua and @gabotechs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alamb commented on PR #15794:
URL: https://github.com/apache/datafusion/pull/15794#issuecomment-2843825721
I merged up and assuming the CI passes I'll merge this PR in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
vbarua commented on PR #15794:
URL: https://github.com/apache/datafusion/pull/15794#issuecomment-2842642259
@alamb this PR should be ready for review
I've checked that this PR consists purely of code moves with no functional
changes, at this point in time, aside from `from_substrait_t
vbarua commented on code in PR #15794:
URL: https://github.com/apache/datafusion/pull/15794#discussion_r2067610862
##
datafusion/substrait/src/logical_plan/consumer/rex/extended_expression.rs:
##
@@ -0,0 +1,109 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+/
vbarua commented on code in PR #15794:
URL: https://github.com/apache/datafusion/pull/15794#discussion_r2067574175
##
datafusion/substrait/src/logical_plan/consumer/mod.rs:
##
@@ -0,0 +1,30 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
vbarua commented on code in PR #15794:
URL: https://github.com/apache/datafusion/pull/15794#discussion_r2067574175
##
datafusion/substrait/src/logical_plan/consumer/mod.rs:
##
@@ -0,0 +1,30 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
Blizzara commented on PR #15794:
URL: https://github.com/apache/datafusion/pull/15794#issuecomment-2838771273
> @Blizzara applied your suggestions. I think scoping expressions and
relations into their own modules made a lot of sense.
Nice! I didn't dive into the details of each file,
gabotechs commented on PR #15794:
URL: https://github.com/apache/datafusion/pull/15794#issuecomment-2829553268
@Blizzara applied your suggestions. I think scoping expressions and
relations into their own modules made a lot of sense.
--
This is an automated message from the Apache Git Serv
gabotechs commented on PR #15794:
URL: https://github.com/apache/datafusion/pull/15794#issuecomment-2825064512
> Thoughts?
I have only a very slight preference for smaller pieces, but since I wasn’t
on the front lines coding this, I trust your judgment much more. I’ll apply
your sugg
Blizzara commented on PR #15794:
URL: https://github.com/apache/datafusion/pull/15794#issuecomment-2824982349
Thanks! This has indeed been a long time todo :) also cc @vbarua
I think personally I'd prefer a bit less files, but that's just a
suggestion: I'd probably do something like:
gabotechs opened a new pull request, #15794:
URL: https://github.com/apache/datafusion/pull/15794
## Which issue does this PR close?
- Closes #13864.
## Rationale for this change
The `consumer.rs` file grew a bit too big (~3400 LOC). Good thing is that
it
13 matches
Mail list logo
