vbarua commented on code in PR #15794: URL: https://github.com/apache/datafusion/pull/15794#discussion_r2067574175
########## datafusion/substrait/src/logical_plan/consumer/mod.rs: ########## @@ -0,0 +1,30 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +mod plan; +mod rel; +mod rex; +mod substrait_consumer; +mod types; +mod utils; + +pub use plan::*; +pub use rel::*; +pub use rex::*; Review Comment: minor: I would recommend that we use `expr` or `expression` for this. I only recognize `rex` as being `Row EXpression` because of my work in Calcite, but it's not really used in this codebase, and it's not used in Substrait either. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
