Blizzara commented on PR #15794: URL: https://github.com/apache/datafusion/pull/15794#issuecomment-2824982349
Thanks! This has indeed been a long time todo :) also cc @vbarua I think personally I'd prefer a bit less files, but that's just a suggestion: I'd probably do something like: - substrait_consumer - literal - types - relations - expressions - utils If you prefer to keep things in smaller pieces, I'd suggest separating expressions and relations into their own folders, and considering combining at least things which are either tightly related (struct_type & named_struct -> types) or used by only one other file (like bound.rs -> window_function.rs). Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
