alamb commented on PR #16155:
URL: https://github.com/apache/datafusion/pull/16155#issuecomment-2906767977
Thank you again for the review @xudong963 and @adriangb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
alamb merged PR #16155:
URL: https://github.com/apache/datafusion/pull/16155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusi
xudong963 commented on code in PR #16155:
URL: https://github.com/apache/datafusion/pull/16155#discussion_r2105700584
##
datafusion/datasource/src/file_scan_config.rs:
##
@@ -232,9 +232,15 @@ pub struct FileScanConfig {
pub struct FileScanConfigBuilder {
object_store_url:
xudong963 commented on code in PR #16155:
URL: https://github.com/apache/datafusion/pull/16155#discussion_r2105699928
##
datafusion/core/src/datasource/physical_plan/parquet.rs:
##
@@ -199,8 +206,14 @@ mod tests {
}
/// run the test, returning the `RoundTripR
xudong963 commented on code in PR #16155:
URL: https://github.com/apache/datafusion/pull/16155#discussion_r2105699811
##
datafusion/core/src/datasource/physical_plan/parquet.rs:
##
@@ -178,7 +185,7 @@ mod tests {
source = source.with_bloom_filter_on_read(false);
alamb commented on PR #16155:
URL: https://github.com/apache/datafusion/pull/16155#issuecomment-2902102618
FYI @xudong963 and @adriangb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
adriangb commented on code in PR #16155:
URL: https://github.com/apache/datafusion/pull/16155#discussion_r2103131713
##
datafusion/datasource/src/file_scan_config.rs:
##
@@ -232,9 +232,13 @@ pub struct FileScanConfig {
pub struct FileScanConfigBuilder {
object_store_url: O
alamb opened a new pull request, #16155:
URL: https://github.com/apache/datafusion/pull/16155
## Which issue does this PR close?
- Related to https://github.com/apache/datafusion/pull/16133
- Related to https://github.com/apache/datafusion/pull/16086
## Rationale for this cha
