xudong963 commented on code in PR #16155:
URL: https://github.com/apache/datafusion/pull/16155#discussion_r2105700584
##########
datafusion/datasource/src/file_scan_config.rs:
##########
@@ -232,9 +232,15 @@ pub struct FileScanConfig {
pub struct FileScanConfigBuilder {
object_store_url: ObjectStoreUrl,
/// Table schema before any projections or partition columns are applied.
- /// This schema is used to read the files, but is **not** necessarily the
schema of the physical files.
- /// Rather this is the schema that the physical file schema will be mapped
onto, and the schema that the
+ ///
+ /// This schema is used to read the files, but is **not** necessarily the
+ /// schema of the physical files. Rather this is the schema that the
+ /// physical file schema will be mapped onto, and the schema that the
/// [`DataSourceExec`] will return.
+ ///
+ /// This is usually the same as the table schema as specified by the
`TableProvider` minus any partition columns.
+ ///
+ /// This probably would be better named `table_schema`
Review Comment:
Yes, yes!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
