alamb opened a new pull request, #16155: URL: https://github.com/apache/datafusion/pull/16155
## Which issue does this PR close? - Related to https://github.com/apache/datafusion/pull/16133 - Related to https://github.com/apache/datafusion/pull/16086 ## Rationale for this change While reviewing https://github.com/apache/datafusion/pull/16133 from @xudong963 I found the test confusing and the term `file_schema` was used for the logical table schema (not the file schema) ## What changes are included in this PR? 1. Update the names of fields and methods in the tests to clarify which `schema` is meant 2. Add additional docstrings to try and make it less confusing ## Are these changes tested? Yes, by CI <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 3. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
