codecov-commenter commented on PR #1874:
URL:
https://github.com/apache/datafusion-comet/pull/1874#issuecomment-2972716900
##
[Codecov](https://app.codecov.io/gh/apache/datafusion-comet/pull/1874?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_ca
trompa commented on PR #1874:
URL:
https://github.com/apache/datafusion-comet/pull/1874#issuecomment-2972493584
@mbutrovich ive locally moved hour/minute/seconds implementation to a macro.
I could potentially be able to reuse if for other functions i dont see
implemented: day/month/year
trompa commented on PR #1874:
URL:
https://github.com/apache/datafusion-comet/pull/1874#issuecomment-2971008063
val df = spark.sql("select hour('1969-12-31 16:00:00.0') AS folded_hour")
== Physical Plan ==
*(1) Project [16 AS folded_hour#0]
+- *(1) Scan OneRowRelation[]
trompa commented on PR #1874:
URL:
https://github.com/apache/datafusion-comet/pull/1874#issuecomment-2970687941
I thinn i can actually just select hour(now()), and parse the query plan,
would that work?
On Fri, Jun 13, 2025, 14:57 Matt Butrovich ***@***.***> wrote:
> *mbutro
mbutrovich commented on PR #1874:
URL:
https://github.com/apache/datafusion-comet/pull/1874#issuecomment-2970308730
I guess the argument is that if you do a `hour()` Spark should
evaluate that expression at planning time and we'll get the resulting literal
in the query. This test evaluates
trompa commented on PR #1874:
URL:
https://github.com/apache/datafusion-comet/pull/1874#issuecomment-2969626724
couldnt find anything.
I am still connecting the dots between native and jvm. If you give me a hint
of where this is actually invoked I can try add it
--
This is an automate
mbutrovich commented on PR #1874:
URL:
https://github.com/apache/datafusion-comet/pull/1874#issuecomment-2968155976
This is looking good so far! I know it's not your change, but it made me
wonder: do you know if we have a test that exercises this code path?
`"Hour(scalar) should be fold in
mbutrovich commented on PR #1874:
URL:
https://github.com/apache/datafusion-comet/pull/1874#issuecomment-2966636271
Thanks for the contribution, @trompa! I'll take a look through this later
today.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
trompa opened a new pull request, #1874:
URL: https://github.com/apache/datafusion-comet/pull/1874
## Which issue does this PR close?
Part of #1819
## Rationale for this change
Part of #1819
## What changes are included in this PR?
Implement hour as Scalar
