mbutrovich commented on PR #1874: URL: https://github.com/apache/datafusion-comet/pull/1874#issuecomment-2970308730
I guess the argument is that if you do a `hour(<literal>)` Spark should evaluate that expression at planning time and we'll get the resulting literal in the query. This test evaluates what happens when the expression runs on table data: https://github.com/apache/datafusion-comet/blob/1d0550f606e9f44ee80304a25a5adb53c3ecb99e/spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala#L455 Maybe we could add a test with a filter that contains an `hour()` expression and make sure that it gets evaluated on the JVM side and doesn't end up in Comet? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
