iffyio merged PR #1675:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr
iffyio commented on PR #1675:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1675#issuecomment-2618088849
@AvivDavid-Satori could you merge in latest main? There's since been some
api changes to `ObjectName` that would be needed in this branch before merging
--
This is an au
AvivDavid-Satori commented on code in PR #1675:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1675#discussion_r1929695871
##
tests/sqlparser_mysql.rs:
##
@@ -2898,6 +2900,21 @@ fn parse_lock_tables() {
mysql().verified_stmt("UNLOCK TABLES");
}
+#[test]
+fn
iffyio commented on code in PR #1675:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1675#discussion_r1928898319
##
src/parser/mod.rs:
##
@@ -11225,6 +11283,11 @@ impl<'a> Parser<'a> {
let alias = self.maybe_parse_table_alias()?;
+// ma
yoavcloud commented on code in PR #1675:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1675#discussion_r1926542015
##
src/parser/mod.rs:
##
@@ -,6 +,64 @@ impl<'a> Parser<'a> {
}
}
+pub fn parse_table_index_hints(&mut self) -> Result,
AvivDavid-Satori commented on code in PR #1675:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1675#discussion_r1926521176
##
src/parser/mod.rs:
##
@@ -,6 +,64 @@ impl<'a> Parser<'a> {
}
}
+pub fn parse_table_index_hints(&mut self) -> Re
iffyio commented on code in PR #1675:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1675#discussion_r1925549414
##
src/parser/mod.rs:
##
@@ -,6 +,64 @@ impl<'a> Parser<'a> {
}
}
+pub fn parse_table_index_hints(&mut self) -> Result,
Par
yoavcloud commented on PR #1675:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1675#issuecomment-2607467010
LGTM! FYI @iffyio @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
yoavcloud commented on PR #1675:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1675#issuecomment-2607209763
@AvivDavid-Satori left some minor comments, otherwise looks good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
yoavcloud commented on code in PR #1675:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1675#discussion_r1925281082
##
src/dialect/mysql.rs:
##
@@ -25,6 +25,11 @@ use crate::{
parser::{Parser, ParserError},
};
+use super::keywords;
+
+pub const RESERVED_FOR
yoavcloud commented on code in PR #1675:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1675#discussion_r1925268062
##
src/dialect/mysql.rs:
##
@@ -111,6 +116,15 @@ impl Dialect for MySqlDialect {
fn supports_user_host_grantee(&self) -> bool {
true
AvivDavid-Satori opened a new pull request, #1675:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1675
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
12 matches
Mail list logo
