yoavcloud commented on code in PR #1675:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1675#discussion_r1925268062
##########
src/dialect/mysql.rs:
##########
@@ -111,6 +116,15 @@ impl Dialect for MySqlDialect {
fn supports_user_host_grantee(&self) -> bool {
true
}
+
+ /// Returns true if the specified keyword should be parsed as a table
factor alias.
Review Comment:
Copying the docs from the Dialect trait to here will likely make it harder
to maintain. If you have dialect-specific documentation to add you should put
it here, otherwise you can leave it blank.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
