yoavcloud commented on code in PR #1675: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1675#discussion_r1926542015
########## src/parser/mod.rs: ########## @@ -8888,6 +8888,64 @@ impl<'a> Parser<'a> { } } + pub fn parse_table_index_hints(&mut self) -> Result<Vec<TableIndexHints>, ParserError> { + let mut hints = vec![]; + while let Some(hint_type) = + self.parse_one_of_keywords(&[Keyword::USE, Keyword::IGNORE, Keyword::FORCE]) Review Comment: I would consider gating the parsing of table hints for both MySQL and MSSQL using a Dialect.supports_table_hints method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org