irenjj commented on PR #15993:
URL: https://github.com/apache/datafusion/pull/15993#issuecomment-2869891230
> @irenjj I've set the default value of this config to "false", and
auto-complete the slt tests. This is one of the changes:
>
> https://private-user-images.githubusercontent.co
irenjj closed pull request #15993: Add configuration for eliminating sort in
subquery
URL: https://github.com/apache/datafusion/pull/15993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
berkaysynnada commented on PR #15993:
URL: https://github.com/apache/datafusion/pull/15993#issuecomment-2869869805
@irenjj I've set the default value of this config to "false", and
auto-complete the slt tests. This is one of the changes:
https://github.com/user-attachments/assets/a277
irenjj commented on PR #15993:
URL: https://github.com/apache/datafusion/pull/15993#issuecomment-2865560162
Thanks @kosiew and @berkaysynnada for your review, PTAL👀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
irenjj commented on PR #15993:
URL: https://github.com/apache/datafusion/pull/15993#issuecomment-2865547053
> Hi @irenjj. Thank you working on this, but did you try to set that config
to false and run the tests?
>
> I think people should see here how the plans are changed if we do so
berkaysynnada commented on PR #15993:
URL: https://github.com/apache/datafusion/pull/15993#issuecomment-2865433405
Hi @irenjj. Thank you working on this, but did you try to set that config to
false and run the tests?
I think people should see here how the plans are changed if we do so
kosiew commented on code in PR #15993:
URL: https://github.com/apache/datafusion/pull/15993#discussion_r2080888952
##
datafusion/sql/src/relation/mod.rs:
##
@@ -241,7 +246,7 @@ fn optimize_subquery_sort(plan: LogicalPlan) ->
Result>
}
match c {
Lo
irenjj opened a new pull request, #15993:
URL: https://github.com/apache/datafusion/pull/15993
## Which issue does this PR close?
- Part of #15886
## Rationale for this change
## What changes are included in this PR?
## Are these changes tes