Re: [PR] Add configuration for eliminating sort in subquery [datafusion]

[via GitHub]

irenjj commented on PR #15993:
URL: https://github.com/apache/datafusion/pull/15993#issuecomment-2869891230

   > @irenjj I've set the default value of this config to "false", and 
auto-complete the slt tests. This is one of the changes:
   > 
   > <img alt="image" width="734" 
src="https://private-user-images.githubusercontent.com/124376117/442507523-a277abe6-c00f-4838-bbbd-4b5270adcd2c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDY5NzI5MjYsIm5iZiI6MTc0Njk3MjYyNiwicGF0aCI6Ii8xMjQzNzYxMTcvNDQyNTA3NTIzLWEyNzdhYmU2LWMwMGYtNDgzOC1iYmJkLTRiNTI3MGFkY2QyYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwNTExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDUxMVQxNDEwMjZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yZDAyY2MyN2Y4YzEwMzY3OTgzMjdiYTlhNGRiYzU2Nzg0Y2Y0YzI3MTQxOGZhYzRkYTkzNDdiY2FlNDQyZWM0JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.nE_BdNz_G9eRnMJ27kO3zkZdbkATZdd-3IwHdWgel1A";>
   > as I said, even if the logical planner doesn't remove the Sort, it's still 
eliminated in the physical planning stage. I also thought it's so because of 
the count(), but if I replace it by another aggregate fn, a SortExec still 
doesn't emerge in the physical plan (I also consider subquery brings unique 
results, so remove the inner group by also to be sure). TLDR, we cannot disable 
subquery sort elimination by disabling it from the logical world only.
   
   That's right, we need to process this more elegantly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org