berkaysynnada commented on PR #15993: URL: https://github.com/apache/datafusion/pull/15993#issuecomment-2865433405
Hi @irenjj. Thank you working on this, but did you try to set that config to false and run the tests? I think people should see here how the plans are changed if we do so (perhaps you can open another PR for that -- I don't know if there is an easier way) As I said in the discussion, I afraid our physical rules are not ready for this. we might either miss some sort eliminations, or possibly eliminate some subquery sorts even if config says opposite. Therefore; I was suggesting enabling this option from lower level to higher. If people still consent this, I couldn't say more but we should add some warnings at least. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
