Re: [PR] Add `FileScanConfigBuilder` [datafusion]

2025-03-28 Thread via GitHub
alamb merged PR #15352: URL: https://github.com/apache/datafusion/pull/15352 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Add `FileScanConfigBuilder` [datafusion]

2025-03-28 Thread via GitHub
alamb commented on PR #15352: URL: https://github.com/apache/datafusion/pull/15352#issuecomment-2762070065 Thanks again @blaginin @mertak-synnada -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Add `FileScanConfigBuilder` [datafusion]

2025-03-27 Thread via GitHub
blaginin commented on code in PR #15352: URL: https://github.com/apache/datafusion/pull/15352#discussion_r2016857051 ## datafusion/datasource/src/file_scan_config.rs: ## @@ -174,6 +175,219 @@ pub struct FileScanConfig { pub batch_size: Option, } +#[derive(Clone)] +pub st

Re: [PR] Add `FileScanConfigBuilder` [datafusion]

2025-03-27 Thread via GitHub
blaginin commented on code in PR #15352: URL: https://github.com/apache/datafusion/pull/15352#discussion_r2016820990 ## datafusion/datasource/src/file_scan_config.rs: ## @@ -645,6 +875,7 @@ impl FileScanConfig { // TODO: This function should be moved into DataSourceExec o

Re: [PR] Add `FileScanConfigBuilder` [datafusion]

2025-03-27 Thread via GitHub
blaginin commented on code in PR #15352: URL: https://github.com/apache/datafusion/pull/15352#discussion_r2016821892 ## datafusion-examples/examples/advanced_parquet_index.rs: ## @@ -498,13 +499,15 @@ impl TableProvider for IndexTableProvider { // provide the fa

Re: [PR] Add `FileScanConfigBuilder` [datafusion]

2025-03-27 Thread via GitHub
mertak-synnada commented on code in PR #15352: URL: https://github.com/apache/datafusion/pull/15352#discussion_r2015906250 ## datafusion/datasource/src/file_scan_config.rs: ## @@ -645,6 +875,7 @@ impl FileScanConfig { // TODO: This function should be moved into DataSource

Re: [PR] Add `FileScanConfigBuilder` [datafusion]

2025-03-26 Thread via GitHub
alamb commented on code in PR #15352: URL: https://github.com/apache/datafusion/pull/15352#discussion_r2015008401 ## datafusion/datasource/src/file_scan_config.rs: ## @@ -326,14 +544,15 @@ impl FileScanConfig { /// # Parameters: /// * `object_store_url`: See [`Self::ob

Re: [PR] Add `FileScanConfigBuilder` [datafusion]

2025-03-25 Thread via GitHub
AdamGS commented on PR #15352: URL: https://github.com/apache/datafusion/pull/15352#issuecomment-2752200316 my 2c - this looks great, I would love to also rename `FileScanConfig` to something else but I get the backwards compatibility concerns. -- This is an automated message from the Apa

Re: [PR] Add `FileScanConfigBuilder` [datafusion]

2025-03-25 Thread via GitHub
blaginin commented on code in PR #15352: URL: https://github.com/apache/datafusion/pull/15352#discussion_r2012431846 ## datafusion-examples/examples/advanced_parquet_index.rs: ## @@ -498,13 +499,15 @@ impl TableProvider for IndexTableProvider { // provide the fa

Re: [PR] Add `FileScanConfigBuilder` [datafusion]

2025-03-25 Thread via GitHub
mertak-synnada commented on code in PR #15352: URL: https://github.com/apache/datafusion/pull/15352#discussion_r2011755617 ## datafusion-examples/examples/advanced_parquet_index.rs: ## @@ -498,13 +499,15 @@ impl TableProvider for IndexTableProvider { // provide