alamb commented on code in PR #15352:
URL: https://github.com/apache/datafusion/pull/15352#discussion_r2015008401
##########
datafusion/datasource/src/file_scan_config.rs:
##########
@@ -326,14 +544,15 @@ impl FileScanConfig {
/// # Parameters:
/// * `object_store_url`: See [`Self::object_store_url`]
/// * `file_schema`: See [`Self::file_schema`]
+ #[allow(deprecated)] // `new` will be removed same time as `with_source`
Review Comment:
this is nice that it will deprecate the old API rather and will guide users
during upgrade
##########
datafusion/datasource/src/file_scan_config.rs:
##########
@@ -174,6 +175,219 @@ pub struct FileScanConfig {
pub batch_size: Option<usize>,
}
+#[derive(Clone)]
+pub struct FileScanConfigBuilder {
Review Comment:
Can we please add comments and examples here? Perhaps just pointing back to
`FileScanConfig`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
