blaginin commented on code in PR #15352:
URL: https://github.com/apache/datafusion/pull/15352#discussion_r2016821892
##########
datafusion-examples/examples/advanced_parquet_index.rs:
##########
@@ -498,13 +499,15 @@ impl TableProvider for IndexTableProvider {
// provide the factory to create parquet reader without
re-reading metadata
.with_parquet_file_reader_factory(Arc::new(reader_factory)),
);
- let file_scan_config = FileScanConfig::new(object_store_url, schema,
file_source)
- .with_limit(limit)
- .with_projection(projection.cloned())
- .with_file(partitioned_file);
+ let file_scan_config =
+ FileScanConfigBuilder::new(object_store_url, schema, file_source)
+ .with_limit(limit)
+ .with_projection(projection.cloned())
+ .with_file(partitioned_file)
+ .build();
// Finally, put it all together into a DataSourceExec
- Ok(file_scan_config.build())
+ Ok(Arc::new(DataSourceExec::new(Arc::new(file_scan_config))))
Review Comment:
do you like
https://github.com/apache/datafusion/pull/15352/commits/748a3354faf7e222c8acd4f28e21cc04010fb152
? Looks cleaner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
