Re: [PATCH] Added get sendmail from .mailrc

2014-01-25 Thread Eric Wong
Brilliantov Kirill Vladimirovich wrote: > Signed-off-by: Brilliantov Kirill Vladimirovich > --- > git-send-email.perl | 18 ++ > 1 file changed, 18 insertions(+) Some documentation references to .mailrc and its format would be nice. > --- a/git-send-email.perl > +++ b/git-send-

Re: [PATCH] Added get sendmail from .mailrc

2014-01-26 Thread Eric Wong
Brilliantov Kirill Vladimirovich wrote: > On 2014-01-25 22:37:21, Eric Wong wrote: > > Brilliantov Kirill Vladimirovich wrote: > > > --- a/git-send-email.perl > > > +++ b/git-send-email.perl > > > @@ -28,6 +28,7 @@ use File::Temp qw/ tempdir tempfile /;

Re: Our cumbersome mailing list workflow

2014-11-27 Thread Eric Wong
Torsten Bögershausen wrote: > On 2014-11-25 01.28, Michael Haggerty wrote: > > * Or I save the emails to a temporary directory (awkward because, Oh > > Horror, I use Thunderbird and not mutt as email client), hope that I've > > guessed the right place to apply them, run "git am", and later try t

Re: [PATCH] git-svn: Support for git-svn propset

2014-12-01 Thread Eric Wong
Alfred Perlstein wrote: > This change allows git-svn to support setting subversion properties. > > Very useful for manually setting properties when committing to a > subversion repo that *requires* properties to be set without requiring > moving your changeset to separate subversion checkout in o

Re: [RFC][PATCH] send-email: add --[no-]xmailer option

2014-12-02 Thread Eric Wong
t this patch. Is there any interest in > having this switch in git-send-email? I wasn't paying attention when the original was sent, but this looks good to me. Acked-by: Eric Wong > I honestly don't like disclosing too much information about my system, > in this case which

Re: Problems cloning existing (probably old) svn repo

2014-12-03 Thread Eric Wong
Cody Goodman wrote: > I recently got this error when trying to git svn clone an existing repo: > > Couldn't open a repository: Unable to connect to a repository at URL > 'file:///home/cody/work/SmartPay': Unable to open an ra_local session > to URL: Unable to open repository 'file:///home/cody/wo

Re: [PATCH] git-svn: Support for git-svn propset

2014-12-06 Thread Eric Wong
t; They are now forward ported to most recent git along with fixes to > deal with files in subdirectories. > > Style and functional changes from Eric Wong have been taken > in thier entirety from: s/thier/their/ > http://marc.info/?l=git&m=141742735608544&w=2 Fwiw, I pref

Re: [PATCH] git-svn: Support for git-svn propset

2014-12-08 Thread Eric Wong
Alfred Perlstein wrote: > Appearing here: > http://marc.info/?l=git&m=125259772625008&w=2 Probably better to use a mid URL here, too http://mid.gmane.org/1927112650.1281253084529659.javamail.r...@klofta.sjsoft.com such a long URL, though... > --- a/perl/Git/SVN/Editor.pm > +++ b/perl/Git/SVN

[PATCH] completion: add --irreversible-delete for format-patch

2014-12-21 Thread Eric Wong
Normally I would use "-D", but send-email (which normally passes options to format-patch) interprets the "-D" as a case-insensitive abbreviation for "--dry-run", preventing format-patch from seeing "-D". Signed-off-by: Eric Wong --- Case-insensitivity str

Re: [PATCH] completion: add --irreversible-delete for format-patch

2014-12-22 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > > Normally I would use "-D", but send-email (which normally passes options > > to format-patch) interprets the "-D" as a case-insensitive abbreviation > > for "--dry-run", preventing format-p

[PULL] git svn updates for master

2014-12-28 Thread Eric Wong
Oops, forgot to Cc: the list Hi Junio, please pull at your convenience. This is probably it for the next few weeks. I was hoping to be able to reproduce (and fix) a weird tempfile problem which commit 822aaf0f ("Git.pm: add specified name to tempfile template") was intended to help track down, b

Re: [PATCH] git-svn: make it play nicely with submodules

2015-01-10 Thread Eric Wong
Ramkumar Ramachandra wrote: > +++ b/git-svn.perl > @@ -337,6 +337,10 @@ for (my $i = 0; $i < @ARGV; $i++) { > # make sure we're always running at the top-level working directory > if ($cmd && $cmd =~ /(?:clone|init|multi-init)$/) { > $ENV{GIT_DIR} ||= ".git"; > + # catch the submodule

Re: [PATCH] Git::SVN: handle missing ref_id case correctly

2015-01-10 Thread Eric Wong
Ramkumar Ramachandra wrote: > Ramkumar Ramachandra wrote: > > -our $default_ref_id = $ENV{GIT_SVN_ID} || 'git-svn'; > > +our $default_ref_id = defined $ENV{GIT_SVN_ID} ? $ENV{GIT_SVN_ID} : > > 'git-svn'; > > This is probably not a functional change; please look at the second hunk. It is funct

Re: [PATCH] git-svn: show progress in working_head_info()

2015-01-10 Thread Eric Wong
Ramkumar Ramachandra wrote: > The working_head_info routine takes a very long time to execute on large > repositories. The least we can do is to comfort users that some progress > is being made. > > Signed-off-by: Ramkumar Ramachandra > --- > I was worried because of the long wait, so I wrote t

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-01-13 Thread Eric Wong
Minty wrote: > § git --version > git version 2.2.1 What about "git svn --version" ? (it'll display the SVN binding version, too) > Any advice / pointers would be welcome -- I'd be happy to run any > tests & I'm reasonably comfortable coding in Perl so happy to poke > around where I can. Great t

Re: git-svn metadata commands performance issue

2015-01-14 Thread Eric Wong
Niluge kiwi wrote: > Hi all, > > In magit (http://magit.github.io/), a popular git frontend within > emacs, there is a git-svn frontend. With a recent refactoring, it was > discovered that git-svn metadata commands (like "git-svn info") are > much slower than git ones: > git svn info: 130-150ms

[PULL] git-svn updates from Ramkumar

2015-01-15 Thread Eric Wong
The following changes since commit 563d4e59bd167fe2eecc5480e3841d878b1c8c2b: Fifth batch for 2.3 cycle (2015-01-14 12:44:03 -0800) are available in the git repository at: git://bogomips.org/git-svn.git for-junio for you to fetch changes up to a94655dcfedc6b266ba32a3d32b0d52a1ce6a928: git

[PATCH] git-svn: lazy load some modules

2015-01-15 Thread Eric Wong
bly improve performance. Signed-off-by: Eric Wong --- git-svn.perl| 13 +++-- perl/Git/SVN.pm | 22 +- perl/Git/SVN/Editor.pm | 3 +-- perl/Git/SVN/Fetcher.pm | 3 +-- perl/Git/SVN/Ra.pm | 5 - 5 files changed, 26 insertions(+), 20 del

Re: [PULL] git-svn updates from Ramkumar

2015-01-15 Thread Eric Wong
Junio C Hamano wrote: > Thanks. No tests necessary/feasible? Just being curious. They seemed simple and obvious enough to me, (and most importantly, didn't trigger regressions). If Ramkumar or anybody else has the time, I'd welcome them. -- To unsubscribe from this list: send the line "unsubscr

Re: [PULL] git-svn updates from Ramkumar

2015-01-15 Thread Eric Wong
Ramkumar Ramachandra wrote: > Junio C Hamano wrote: > > To which a natural reaction was "Can the existing breakage > > demonstrated by a test?". > > There's a lot to do, if we really want to dig deeper. > > The second git-svn-basic test onwards doesn't pass for me, so I really > can't do much in

Re: [PULL] git-svn updates from Ramkumar

2015-01-15 Thread Eric Wong
Ramkumar Ramachandra wrote: > Eric Wong wrote: > > I haven't seen this before. Which SVN Perl binding version are you > > using? Perhaps your "svnadmin" tool is from a different SVN version > > or installation of SVN than your Perl bindings? > > I

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-01-29 Thread Eric Wong
Valery Yundin wrote: > Tested on: > git-svn version 2.3.0.rc2 (svn 1.8.11) - FAIL > git-svn version 2.2.2 (svn 1.8.10) - FAIL > git-svn version 1.8.4.5 (svn 1.8.11) - WORKS Thank you for that info. Do you think you can bisect which versions/revisions of git-svn introduced that failure for us? I

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-01-29 Thread Eric Wong
bit :/ Increasing --log-window-size will help you run longer without the error, but that's not ideal as it can also eat memory. ---8<-- From: Eric Wong Subject: [PATCH] git-svn: destroy all tempfiles when reloading RA This may fix the errors some user

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-01-29 Thread Eric Wong
ply my patch to the appropriate maintenance tracks with Tested-by:s? I'm going offline in a few hours and don't think I'll be around much the next week or so. Thanks. > Thanks, > Valery > > On 30 January 2015 at 01:22, Eric Wong wrote: > > Vale

"git status" should warn/error when it cannot lists a directory

2015-02-02 Thread Andrew Wong
When "git status" recurses a directory that isn't readable (but executable), it should print out a warning/error. Currently, if there are untracked files in these directories, git wouldn't be able to discover them. Ideally, "git status" should return a non-zero exit code as well. The problem seems

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-02-12 Thread Eric Wong
Valery Yundin wrote: > On 31 January 2015 at 13:51, Nico Schlömer wrote: > > I tried the patch and I still get > > ``` > > [...] > > r100 = e2a9b5baa2cebb18591ecb04ff350410d52f36de (refs/remotes/git-svn) > > Unexpected result returned from git cat-file at > > /home/nschloe/share/perl/5.18.2/Git/S

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-02-16 Thread Eric Wong
Nico Schlömer wrote: > I just double-checked and I can only produce this issue on one machine > (tested on 3). Apparently, this is has nothing to do with Git itself > then. > > Any ideas of what could be wrong? What's different about that one machine? e.g. SVN version, 64 vs 32-bit, Perl version

Re: [PATCH] git-svn: Configure a prompt callback for gnome_keyring.

2013-08-29 Thread Eric Wong
Matthijs Kooijman wrote: > Hi folks, > > any chance this patch can be merged? It's probably fine. Does anybody else have testing/feedback? I haven't used git-svn/SVN in years, and I don't use GNOME (nor much GUI). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of

Re: [PATCH] git-svn: Configure a prompt callback for gnome_keyring.

2013-08-29 Thread Eric Wong
Edward Rudd wrote: > Where is a link to the latest patch? I can give it a quick once-over > with one of my git-svn'ed game ports I'm working on. (due for > launching on the 10th.. WOOHOO!) http://mid.gmane.org/1371573490-21973-1-git-send-email-matth...@stdin.nl Thanks! -- To unsubscribe from this

Re: [PATCH] git-svn: Fix termination issues for remote svn connections

2013-09-05 Thread Eric Wong
om happening. > Thanks. Please sign-off your patch. > > I am Cc'ing Kyle McKay who apparently had some experience working > with git-svn with newer svn that can only use serf, hoping that we > can get an independent opinion/test just to be sure. Also Cc'ed is &g

Re: [PATCH] git-svn.txt: mention how to rebuild rev_map files

2013-09-25 Thread Eric Wong
Jonathan Nieder wrote: > Keshav Kini wrote: > > + tracking. If necessary, rebuild the .git/svn/\*\*/.rev_map.* > > + files, given the requisite information exists in commit > > + messages (see the svn.noMetadata config option for more > > + information). The name of the [svn-remote "..."

Re: [RFC/PATCH] git svn: Set default --prefix='origin/' if --prefix is not given

2013-09-30 Thread Eric Wong
Johan Herland wrote: > git-svn by default puts its Subversion-tracking refs directly in > refs/remotes/*. This runs counter to Git's convention of using > refs/remotes/$remote/* for storing remote-tracking branches. > Furthermore, combining git-svn with regular git remotes run the risk of > clobb

Re: [RFC/PATCH] git svn: Set default --prefix='origin/' if --prefix is not given

2013-10-03 Thread Eric Wong
Johan Herland wrote: > On Tue, Oct 1, 2013 at 6:07 AM, Eric Wong wrote: > > How about we put a big warning of impending change in there for now and > > wait until git 1.9/2.0 to make the actual change? > > Sounds sensible. What should the warning look like, and where shoul

Re: [PATCH] git-svn: fix signed commit parsing

2013-10-09 Thread Eric Wong
xt: reword description of gc command git-svn.txt: replace .git with $GIT_DIR git-svn.txt: elaborate on rev_map files Nicolas Vigier (1): git-svn: fix signed commit parsing Documentation/git-svn.txt | 46 +- git-svn.perl

Re: [PATCH v2 0/4] git-svn.txt: miscellaneous changes

2013-10-10 Thread Eric Wong
Keshav Kini wrote: > I'm not sure if this was the best way to split my changes into commits. > Please let me know if it wasn't. > > Keshav Kini (4): > git-svn.txt: fix AsciiDoc formatting error > git-svn.txt: reword description of gc command > git-svn.txt: replace .git with $GIT_DIR > git

[PATCH] http: enable keepalive on TCP sockets

2013-10-12 Thread Eric Wong
s to error out after a few minutes/hours depending on the keepalive settings of the system. I noticed this problem with some non-interactive cronjobs getting hung when talking to HTTP servers. Signed-off-by: Eric Wong --- http.c | 22 ++ 1 file changed, 22 insertions(+) di

Re: [RFC/PATCHv3 2/3] git-svn: Warn about changing default for --prefix in Git v2.0

2013-10-12 Thread Eric Wong
ange, both in the git-svn > manual page, and on stderr when running init/clone in the "multi-mode" > without providing a --prefix. > > Cc: Eric Wong > Signed-off-by: Johan Herland Thanks! 1/2 and 2/3 signed-off and pushed to git://git.bogomips.org/git-svn.git -- To unsu

Re: [PATCH] http: enable keepalive on TCP sockets

2013-10-13 Thread Eric Wong
Daniel Stenberg wrote: > On Sat, 12 Oct 2013, Eric Wong wrote: > > >This is a follow up to commit > >e47a8583a20256851e7fc882233e3bd5bf33dc6e (enable SO_KEEPALIVE for > >connected TCP sockets). > > Just keep in mind that TCP keep-alive is enabled in awkwardly many

Re: [PATCH 1/2] Add password parameter to git svn commands and use it when provided instead of defaulting to end-user prompt

2013-10-14 Thread Eric Wong
Jonathan Nieder wrote: > Hi, > > arnaud.brej...@gmail.com wrote: > > > Signed-off-by: Arnaud Brejeon gmail.com> > > Thanks. > > Can you say a little more about the context? Do you run a script that > wants to pass a password to 'git svn', do you type it each time on the > command line, or so

Re: [PATCH 1/2] Add password parameter to git svn commands and use it when provided instead of defaulting to end-user prompt

2013-10-14 Thread Eric Wong
Jeff King wrote: > On Mon, Oct 14, 2013 at 06:40:05PM +, Eric Wong wrote: > > > > arnaud.brej...@gmail.com wrote: > > > > > > > Signed-off-by: Arnaud Brejeon gmail.com> > > > > > > Thanks. > > > > > > Can you sa

Re: [PATCH] http: enable keepalive on TCP sockets

2013-10-14 Thread Eric Wong
Jeff King wrote: > On Mon, Oct 14, 2013 at 05:27:39AM +, Eric Wong wrote: > > Daniel Stenberg wrote: > > > On Sat, 12 Oct 2013, Eric Wong wrote: > > > > > > >This is a follow up to commit > > > >e47a8583a20256851e7fc882233e3bd5bf33dc6e (e

Re: [PATCH] http: use curl's tcp keepalive if available

2013-10-14 Thread Eric Wong
Jeff King wrote: > On Mon, Oct 14, 2013 at 11:38:39PM +, Eric Wong wrote: > > > I wanted it to work as older curl first (since I noticed this > > on an old server). But your patch on top of mine looks reasonable, > > thanks. > > Makes sense. Here it is with a

Re: [PATCH] http: use curl's tcp keepalive if available

2013-10-14 Thread Eric Wong
Jeff King wrote: > I am more concerned with Windows, which may not compile your original > patch at all. The code I introduced in e47a8583a20256851e7fc882233e3bd5bf33dc6e ("enable SO_KEEPALIVE for connected TCP sockets" Dec 2011) didn't trigger the addition of any new #ifdef guards. I think we'r

Re: Request: timeout option for remote operations, esp. "git fetch"

2013-11-10 Thread Eric Wong
"H. Peter Anvin" wrote: > When a remote server is unavailable or very slow, some git commands can > stall out indefinitely. It would be a very good thing if remote > commands -- but especially git fetch -- could be given a timeout. We've had SO_KEEPALIVE on git and ssh transports since e47a8583

Re: [PATCH] git-svn: fix localtime=true on non-glibc environments

2015-02-25 Thread Eric Wong
Junio C Hamano wrote: > Ryuichi Kokubo writes: > > > git svn uses POSIX::strftime('%s', $sec, $min, ...) to make unix epoch time. > > But lowercase %s formatting character is a GNU extention. This causes > > problem > > in git svn fetch --localtime on non-glibc systems, such as msys or cygwin.

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-02-25 Thread Eric Wong
Nico Schlömer wrote: > Thanks Kyle for the patch! I applied it and ran > ``` > git svn clone https://geuz.org/svn/gmsh/trunk > ``` > Unfortunately, I'm still getting > ``` > [...] > r100 = e2a9b5baa2cebb18591ecb04ff350410d52f36de (refs/remotes/git-svn) > error closing pipe: Bad file descriptor at

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-02-26 Thread Eric Wong
"Kyle J. McKay" wrote: > The updated patch with the additional fix is below. Thanks, signed-off and pushed to master on git://bogomips.org/git-svn I've dropped my "destroy all tempfiles..." patch. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord

[PULL] git-svn updates for master

2015-02-26 Thread Eric Wong
in the git repository at: git://bogomips.org/git-svn.git master for you to fetch changes up to e0b4cad4fd77e4cd787c3ed26e7650fc4de8bcd2: Git::SVN::*: avoid premature FileHandle closure (2015-02-26 20:19:41 +) Eric Wong (1

Re: git-svn: Fetch svn branches only and have git recognize them as branches?

2015-03-12 Thread Eric Wong
Brian Koehmstedt wrote: > My latest failed attempt was this: > > [svn-remote "svn"] > url = http://abc.com/repo/branches > fetch = :refs/remotes/svn/branches > branches = *:refs/remotes/svn/* > > git svn fetch svn > This fetched all the branch directories as one branch.

Re: git svn import failure : write .git/Git_svn_hash_BmjclS: Bad file descriptor

2015-03-23 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > "Kyle J. McKay" wrote: > >> The updated patch with the additional fix is below. > > > > Thanks, signed-off and pushed to master on git://bogomips.org/git-svn > > I've dropped my "destroy all

Re: [WIP/RFH/PATCH 3/3] t/lib-git-svn: adjust config to apache 2.4

2015-04-08 Thread Eric Wong
Michael J Gruber wrote: > The current config is tailored to apache 2.2. Apache 2.4 fails to start > with it. > > Adjust the config to apache 2.4. > > Signed-off-by: Michael J Gruber > --- 1/3 and 2/3 tested fine on Debian stable (wheezy). You can add my Tested-by to 1/3 and my S-o-b to 2/3. .

Re: [WIP/RFH/PATCH 3/3] t/lib-git-svn: adjust config to apache 2.4

2015-04-09 Thread Eric Wong
Michael J Gruber wrote: > So debian stable has apache 2.2? That explains why many don't see these > problems. Right. > So, before 3/3, t9118 and such do run the web server and test git-svn > against that for you? Yes. -- To unsubscribe from this list: send the line "unsubscribe git" in the body

Business Vorschlag

2013-06-27 Thread PETER WONG
an einer Zusammenarbeit mit mir Kontakt mit mir durch meine private E-Mail interessiert ppwong...@yahoo.com.hk für weitere Details. Ihre erste Reaktion auf dieses Schreiben wird geschätzt. Mit freundlichen Grüßen, Mr. Peter Wong E-mail: ppwong...@yahoo.com.hk -- To unsubscribe from this list

[PATCH] git add -e: Explicitly specify that patch should have no color

2013-07-18 Thread Andrew Wong
tly setting use_color to 0, we can ensure the diff output has no color codes in it. Signed-off-by: Andrew Wong --- builtin/add.c | 1 + 1 file changed, 1 insertion(+) diff --git a/builtin/add.c b/builtin/add.c index f45d9d4..8266a9c 100644 --- a/builtin/add.c +++ b/builtin/add.c @@ -343,6 +343,

Re: [PATCH v4 2/2] git-svn: allow git-svn fetching to work using serf

2013-07-18 Thread Eric Wong
Jonathan Nieder wrote: > (cc-ing Eric Wong, who maintains git-svn and knows both it and > the libsvn perl bindings much better than I do) I doubt that's the case anymore. I've hardly looked at SVN in many years, now. Anyways, if the patches: 1) do not introduce regressio

Mail Back If Interested!

2013-08-14 Thread YONG WONG
Good Day, I appologize for using this medium of internet to reach you, though it has been greatly abused, but I chose to reach you because it is still the fastest meansof communication in the world,however this correspondent is unofficial and private. My name is Yong Wong, I work with the

Re: git-svn: What is --follow-parent / --no-follow-parent for?

2012-11-28 Thread Eric Wong
Sebastian Leske wrote: > However, this does not make sense to me: This sounds like there is no > good reason *not* to enable this option. So why is it there? And in > what situation might I want to use "--no-follow-parent"? Speed. Following long/convoluted histories can take a long time. Someti

Re: [PATCH v2 0/4] git-svn: More docs for branch handling in

2012-12-04 Thread Eric Wong
Junio C Hamano wrote: > I've sent comments on small nits I found but overall they looked > quite well researched. Will tentatively queue on the 'pu' branch, > expecting further updates and Acks from people involved polishing > these patches. > > Thanks for writing it up. Thanks all. I think th

Re: [PATCH v3 1/4] git-svn: Document branches with at-sign(@).

2012-12-05 Thread Eric Wong
stimage, but there actually are only 52. I'll hand-tweak the > message and apply. Thanks all, this series Acked-by: Eric Wong -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] git-svn: teach find-rev to find near matches

2013-01-17 Thread Eric Wong
ooked like this": > > git svn find-rev --before \ > r$(git --git-dir=/over/there.git svn find-rev HEAD) > > Signed-off-by: John Keeping Thanks. Signed-off-by: Eric Wong I've pushed this out to git://bogomips.org/git-svn along with a few other things I seem t

Re: [PATCH] git-svn: do not escape certain characters in paths

2013-01-19 Thread Eric Wong
Peter Wu wrote: > Signed-off-by: Peter Wu Thanks, Signed-off-by: Eric Wong Will push. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: bug: git-svn seg fault during 'git svn fetch' due to perl < 5.10

2013-01-19 Thread Eric Wong
Durham Goode wrote: > In git 1.8.1, when we do 'git svn fetch' on a large repo, we're seeing a > seg fault. It's caused by git-svn trying to parse a large yaml file > (introduced in > https://github.com/git/git/commit/68f532f4ba888f277637a94b4a49136054df0540 > ) which encounters a perl regex sta

[PULL] git-svn updates for 1.8.3-rc2

2013-05-10 Thread Eric Wong
reate mode 100755 t/t9147-git-svn-include-paths.sh -- Eric Wong -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] git-gui: fix file name handling with non-empty prefix

2013-05-11 Thread Andrew Wong
Sorry for the late reply. I was able to reproduce the problem that you were describing a while ago. And your patch indeed fixes it. It's a much more elegant way of dealing with the "absolute vs relative" path problem that I was trying to fix. Thanks! As for Pat, I'm not sure wha'ts going on with

Re: [PATCH resend 0/2] git-svn: improve documentation of multiple fetch lines

2013-05-14 Thread Eric Wong
Jonathan Nieder wrote: > I last sent these patches as an RFC a year and a half or so ago[1]. > Nathan seemed to like them and they still seem valid, so thought > I'd resubmit. :) Thanks, both applied. Sorry for forgetting :x -- To unsubscribe from this list: send the line "unsubscribe git" in th

Re: [PATCH] git-svn: introduce --parents parameter for commands branch and tag

2013-05-14 Thread Eric Wong
Tobias Schulte wrote: > This parameter is equivalent to the parameter --parents on svn cp commands > and is useful for non-standard repository layouts. This looks useful. A few minor cosmetic issues. > +++ b/Documentation/git-svn.txt > @@ -298,6 +298,11 @@ where is the name of the SVN reposito

Re: [PATCHv2 03/10] refs.c: Refactor code for mapping between shorthand names and full refnames

2013-05-15 Thread Eric Wong
Johan Herland wrote: > Unfortunately, using "refs/remotes/%1/%*" instead of "refs/remotes/%*" > breaks a number of git-svn tests which puts refs directly within > refs/remotes/, and then does things like "git reset --hard trunk" > (expecting trunk -> refs/remotes/trunk, which the refs/remotes/%1/%

Re: [PATCH v2] git-svn: introduce --parents parameter for commands branch and tag

2013-05-20 Thread Eric Wong
Tobias Schulte wrote: > This parameter is equivalent to the parameter --parents on svn cp commands > and is useful for non-standard repository layouts. > > Signed-off-by: Tobias Schulte Signed-off-by: Eric Wong Applied and pushed, thanks. -- To unsubscribe from this list: s

Re: [PATCH v2] git-svn: introduce --parents parameter for commands branch and tag

2013-05-20 Thread Eric Wong
erl | 19 - t/t9167-git-svn-cmd-branch-subproject.sh | 48 3 files changed, 97 insertions(+), 6 deletions(-) create mode 100755 t/t9167-git-svn-cmd-branch-subproject.sh -- Eric Wong -- To unsubscribe from this list: send the l

Re: [PATCH] git-svn: Support custom tunnel schemes instead of SSH only

2013-03-26 Thread Eric Wong
Sebastian Schuberth wrote: > This originates from an msysgit pull request, see: > > https://github.com/msysgit/git/pull/58 > > Signed-off-by: Eric Wieser > Signed-off-by: Sebastian Schuberth Thanks, looks obviously correct. Signed-off-by: Eric Wong > diff --git a/perl

Re: [PATCH] git-svn: Support custom tunnel schemes instead of SSH only

2013-03-27 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > > > git-svn: Support custom tunnel schemes instead of SSH only (2013-03-27 > > 04:28:04 +) > > Thanks. Will pull. > > By the way, did nobody in the patch chain find the log message > problematic? It does

Re: [PATCH] perl: redirect stderr to /dev/null instead of closing

2013-04-03 Thread Eric Wong
Thomas Rast wrote: > Closing stderr is a bad idea anyway: there is a very real chance that > we print fatal error messages to some other file that just happens to > be opened on the now-free FD 2. So let's not do that. 100% agreed. FD 0, 1, and 2 should not be closed, way too much potential for

Re: [PATCH] git-svn: avoid self-referencing mergeinfo

2013-04-03 Thread Eric Wong
o is set to better match the behavior of SVN. Update the > svn-mergeinfo-push test. > > Signed-off-by: Michael Contreras > Reported-by: Avishay Lavie Acked-by: Eric Wong 80-column wrapped version pushed to git://bogomips.org/git-svn master (commit e5ee78e1f0835410a37bfa38e1ff5e1a82f

[PATCH] update pasky's email address

2013-04-03 Thread Eric Wong
Mail to pa...@suse.cz is bouncing. Signed-off-by: Eric Wong --- I noticed this when I attempted to reply to Thomas's email: http://mid.gmane.org/f3d238a4c6cfbc6d68f2c4fa285aefa93acf4b7d.1365027616.git.tr...@inf.ethz.ch .mailmap| 1 + Document

Re: [PATCH] update pasky's email address

2013-04-04 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > > Mail to pa...@suse.cz is bouncing. > > > > Signed-off-by: Eric Wong > > --- > > I noticed this when I attempted to reply to Thomas's email: > > > > http://mid.gmane.org/f3d238a4c6cfbc6d68f2

Re: [PATCH v2 1/2] perl: redirect stderr to /dev/null instead of closing

2013-04-04 Thread Eric Wong
Thomas Rast wrote: > As pointed out by Eric Wong (thanks), the initial close needs to go: > die() would again write nowhere if we close STDERR beforehand. > > Signed-off-by: Thomas Rast Acked-by: Eric Wong Thanks. -- To unsubscribe from this list: send the line "unsubscribe

Re: git instaweb - share all project files

2013-04-13 Thread Eric Wong
Jakub Narębski wrote: > Unfortunately it turns out such simple solution doesn't really work. > > First, for some reason Firefox 20.0 refuses to follow file:/// link, > even though it shows correctly worktree if copy'n'pasted as URL in new > window / new tab. I can confirm this behavior with chro

Re: [PATCHv2 6/8] t9114.2: Don't use --track option against "svn-remote"-tracking branches

2013-04-20 Thread Eric Wong
Acked-by: Eric Wong -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Fwd: [PATCH] git-svn: added an --include-path flag

2013-04-24 Thread Eric Wong
ed unit tests too. No forgivness necessary, it's standard practice to Cc maintainers in git (and Linux kernel) patch submissions :) (Re-adding git ML-as Cc) > --- /dev/null > +++ b/t/t9147-git-svn-include-paths.sh > @@ -0,0 +1,150 @@ > +#!/bin/sh > +# > +# Copyright (c) 2

Re: [PATCH] git-svn: added an --include-path flag (resent fixing mail format)

2013-05-01 Thread Eric Wong
@deleted_gpath %added_placeholder $repo_id/; Please wrap long lines at 80 columns. > --- /dev/null > +++ b/t/t9147-git-svn-include-paths.sh > @@ -0,0 +1,150 @@ > +#!/bin/sh > +# > +# Copyright (c) 2009 Vitaly Shukela > +# Copyright (c) 2009 Eric Wong > +#

Re: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-01 Thread Eric Wong
Ilya Basin wrote: > JCH> comment line "# added by git-svn only to keep the directory" and > JCH> consider a directory that has nothing but .gitignore that consists > JCH> of only that exact comment line an "added placeholder" directory to > JCH> work it around. > Sounds good, but it's not I who de

Re: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-01 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > Ilya Basin wrote: > >> JCH> comment line "# added by git-svn only to keep the directory" and > >> JCH> consider a directory that has nothing but .gitignore that consists > >> JCH> of only that

Re: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-02 Thread Eric Wong
Ilya Basin wrote: > EW> My personal philosophy has always been: git svn users should leave > EW> no trace or indication they're using a non-standard SVN client. > > Placeholders aren't pushed back to svn. Right, I was confused, as I often am :x -- To unsubscribe from this list: send the line "un

Re: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-02 Thread Eric Wong
Ilya Basin wrote: > Hi. I won't send you updated patches until I import and test my huge > repo. Everything will be here: > https://github.com/basinilya/git/commits/v1.8.2.2-git-svn-fixes > > At the moment I've decided not to implement the Junio's proposal: > > >> JCH> comment line "# added by gi

Re: [PATCH 4/5] git-svn: fix bottleneck in stash_placeholder_list()

2013-05-08 Thread Eric Wong
Ilya Basin wrote: > Hi Eric. I'm out of spare time and I still unable to import my repo. > The code of SVN.pm is too complex. Please help me. Sorry, most what I do nowadays for git-svn is ACK/NACK changes. git-svn has made itself obsolete for most contributors, myself included; so it's hard for

Re: [PATCH] Git::SVN::*: add missing "NAME" section to perldoc

2013-05-08 Thread Eric Wong
Jonathan Nieder wrote: > Just noticed this by running a tool to sanity-check my build result. > I hadn't noticed before because I hadn't been installing the manpages. > Anyway, perhaps the patch can be useful. Thanks, signed-off and applied, will push. -- To unsubscribe from this list: send the l

Re: [PATCH] git-svn: added an --include-path flag

2013-05-08 Thread Eric Wong
Paul Walmsley wrote: > The SVN::Fetcher module is now able to filter for inclusion as well > as exclusion (as used by --ignore-path). Also added tests, documentation > changes and git completion script. > > If you have an SVN repository with many top level directories and you > only want a git-sv

Re: Fix git-svn for SVN 1.7

2012-08-21 Thread Eric Wong
Junio C Hamano wrote: > Unless you found a reason not to in the meantime, that is. Is what > I have on 'pu' still good, or do you (Eric and/or Michael) have any > updates you'd rather have me pull instead? No updates, everything is still good. -- To unsubscribe from this list: send the line "uns

Re: [PATCH/RFC] git svn: don't introduce new paragraph for git-svn-id

2012-08-21 Thread Eric Wong
Robert Luberda wrote: > I have been quite a busy recently, so it took me longer that I thought. No worries, thanks for following up. > It was quite hard for me to think some sensible option name, and finally > have chosen --trim-svn-log (svn.trimsvnlog as config key name). Please > let me know i

Re: [PATCH/RFC] git svn: handle errors and concurrent commits in dcommit

2012-08-21 Thread Eric Wong
fixes `ambiguous redirect' error given by bash. [ew: fix misspelled test name, also eliminate space after ">>" to conform to guidelines] Signed-off-by: Eric Wong --- ...n-dcommit-concrrent.sh => t9164-git-svn-dcommit-concurrent.sh} | 8 1 file changed,

Re: [PATCH 1/2] git-svn.perl: consider all ranges for a given merge, instead of only tip-by-tip

2012-08-21 Thread Eric Wong
Steven Walter wrote: > Consider the case where you have trunk, branch1 of trunk, and branch2 of > branch1. trunk is merged back into branch2, and then branch2 is > reintegrated into trunk. The merge of branch2 into trunk will have > svn:mergeinfo property references to both branch1 and branch2.

Re: [PATCH/RFC] git svn: handle errors and concurrent commits in dcommit

2012-08-25 Thread Eric Wong
Robert Luberda wrote: > Eric Wong wrote: > > Oops, I'll push the following out since Junio already merged your > > original: > > I can see that you haven't pushed the change yet. Maybe it would be a > good idea to fix other style mistakes (extra spaces after re

Re: [PATCH/RFC] git svn: don't introduce new paragraph for git-svn-id

2012-08-25 Thread Eric Wong
Robert Luberda wrote: > Junio C Hamano wrote: > > Eric Wong writes: > >> > >> I think having "svn" in "svn.trimsvnlog" twice is redundant and not ideal. > >> Perhaps just --trim-log and svn.trimlog? > > > > Do we ever want to

[RFC] Add "edit" action for interactive rebase?

2012-09-10 Thread Andrew Wong
ssues. I wonder if any others have ever ran into this situation, and would this be a useful feature to have in interactive rebase? Comments? This patch doesn't have any documentations yet. I'll add some documentations in another patch if we decide to include this. Andrew Wong (1):

[PATCH] rebase -i: Teach "--edit" action

2012-09-10 Thread Andrew Wong
This allows users to edit the todo list while they're in the middle of an interactive rebase. Signed-off-by: Andrew Wong --- git-rebase--interactive.sh | 6 ++ git-rebase.sh | 14 ++ 2 files changed, 20 insertions(+) diff --git a/git-rebase--interactive.sh

Re: [PATCH] rebase -i: Teach "--edit" action

2012-09-10 Thread Andrew Wong
On Mon, Sep 10, 2012 at 12:25 PM, Matthieu Moy wrote: > Indent with space. Please, use tabs (same below). Ah, thanks. Good catch. > Just "edit" may be a bit misleading, as we already have the "edit" > action inside the todolist. I'd call this --edit-list to avoid > ambiguity. I thought that mig

Re: [PATCH] rebase -i: Teach "--edit" action

2012-09-10 Thread Andrew Wong
On Mon, Sep 10, 2012 at 2:46 PM, Jeff King wrote: > On Mon, Sep 10, 2012 at 08:36:43PM +0200, Johannes Sixt wrote: > >> > [1] It does preclude using "--edit" to make a note about a later commit >> > while you are in the middle of resolving a conflict or something. >> > You'd have to do it

Re: [RFC] Add "edit" action for interactive rebase?

2012-09-10 Thread Andrew Wong
On Mon, Sep 10, 2012 at 2:28 PM, Johannes Sixt wrote: > Did you think about what can go wrong? For example, starting with this > todo sheet: > > exec false > pick 1234567 Ah, that's definitely a problem. I was going to say we probably just to check the "done" file, same as the one we do for

Re: [PATCH] rebase -i: Teach "--edit" action

2012-09-10 Thread Andrew Wong
On Mon, Sep 10, 2012 at 3:57 PM, Junio C Hamano wrote: > Hrm... They see the contents of the todo file immediately after > they say "rebase --edit-todo" and the sole reason they said that > command is because they wanted to edit the todo file. Is it likely > they need a reminder? Yes, it's not

Re: Interactive rebase with pre-built script?

2012-09-12 Thread Andrew Wong
On 09/11/2012 02:32 AM, Peter Krefting wrote: Now, to my question. Is there an easy way to run interactive rebase on the upstream branch with this recipe? The best we have come up with so far is git checkout master # the upstream branch git rebase -i HEAD~ and then just append everything

<    3   4   5   6   7   8   9   10   >