Paul Walmsley <pjwh...@gmail.com> wrote: > The SVN::Fetcher module is now able to filter for inclusion as well > as exclusion (as used by --ignore-path). Also added tests, documentation > changes and git completion script. > > If you have an SVN repository with many top level directories and you > only want a git-svn clone of some of them then using --ignore-path is > difficult as it requires a very long regexp. In this case it's much > easier to filter for inclusion.
Thanks, comments inline. A Signed-off-by is necessary (especially for new contributors) (not _my_ policy, but project policy, see Documentation/SubmittingPatches) > @@ -1,5 +1,5 @@ > package Git::SVN::Fetcher; > -use vars qw/@ISA $_ignore_regex $_preserve_empty_dirs $_placeholder_filename > +use vars qw/@ISA $_ignore_regex $_include_regex $_preserve_empty_dirs > $_placeholder_filename > @deleted_gpath %added_placeholder $repo_id/; Please wrap long lines at 80 columns. > --- /dev/null > +++ b/t/t9147-git-svn-include-paths.sh > @@ -0,0 +1,150 @@ > +#!/bin/sh > +# > +# Copyright (c) 2009 Vitaly Shukela > +# Copyright (c) 2009 Eric Wong > +# I already commented on this in the previous email, please add your own copyright header (you can add a note saying this is based on t9134 by Vitaly). Thanks again. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
