Reply

2017-11-29 Thread Wong
I have something very confidential and private to discuss with you

Re: git svn clone fails

2015-09-01 Thread Eric Wong
Jörg Schaible wrote: > Is there really no other place for a bug report? This will simply vanish in > the list's noise ... These messages do get seen and read. (And I would not have seen this message if it were posted anywhere else). But I don't have much time or motivation to work on git svn s

Re: [PATCH] git-svn: parse authors file more leniently

2015-09-10 Thread Eric Wong
; Signed-off-by: Michael J Gruber Thanks. Signed-off-by: Eric Wong And pushed to master of git://bogomips.org/git-svn (commit f7c6de0ea1bd5722a1181c6279676c6831b38a34) By the way, I also had some other patches sitting around for you. Did you ever have time to revisit them? (I haven't) t

Re: [PATCH] git-svn: make batch mode optional for git-cat-file

2015-09-22 Thread Eric Wong
Victor Leschuk wrote: > The thing is that git-cat-file keeps growing during work when running > in "batch" mode. See the figure attached: it is for cloning a rather > small repo (1 hour to clone about ~14000 revisions). However the clone > of a large repo (~28 revisions) took about 2 weeks and

Re: [PATCH] git-svn: make batch mode optional for git-cat-file

2015-09-22 Thread Eric Wong
Eric Wong wrote: > Victor Leschuk wrote: > > The thing is that git-cat-file keeps growing during work when running > > in "batch" mode. See the figure attached: it is for cloning a rather > > small repo (1 hour to clone about ~14000 revisions). However the clo

Re: [PATCH] git-svn: make batch mode optional for git-cat-file

2015-09-23 Thread Eric Wong
Victor Leschuk wrote: > Hello Eric, thanks for looking into it. > > >> git-cat-file has outgrown the parent perl process several times > >> (git-cat-file - ~3-4Gb, perl - 400Mb). > > > Ugh, that sucks. > > Even the 400Mb size of Perl annoys me greatly and I'd work > > on fixing it if I had more

[PATCH] prune: keep files created after process start

2016-06-18 Thread Eric Wong
" in a different terminal, and ensuring the loose object remains after "git prune" completes. Signed-off-by: Eric Wong --- I'm somewhat surprised this check didn't already exist; but maybe nobody else runs prune manually, anymore. builtin/prune.c | 6 -- 1 file ch

Re: [PATCH] prune: keep files created after process start

2016-06-18 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > I'm somewhat surprised this check didn't already exist; > > but maybe nobody else runs prune manually, anymore. > > The only time an end user would run "git prune" in their > repositories with working tr

Re: [PATCH] prune: keep files created after process start

2016-06-19 Thread Eric Wong
Andreas Schwab wrote: > Eric Wong writes: > > > @@ -21,7 +22,7 @@ static int prune_tmp_file(const char *fullpath) > > struct stat st; > > if (lstat(fullpath, &st)) > > return error("Could not stat '%s'", fullpath); >

Re: may be bug in svn fetch no-follow-parent

2016-06-20 Thread Eric Wong
+Cc: a bunch of folks who may know better how mergeinfo works in git-svn Александр Овчинников wrote: > Why git svn fetch try to handle mergeinfo changes when > no-follow-parent is enabled? It probably should not... --no-follow-parent isn't a common config, though. Can you try the patch below?

http-backend fatal error message on shallow clone

2016-06-21 Thread Eric Wong
I noticed "fatal: The remote end hung up unexpectedly" in server logs from shallow clones. Totally reproducible in the test cases, too. The following change shows it: diff --git a/t/t5561-http-backend.sh b/t/t5561-http-backend.sh index 90e0d6f..cfa55ce 100755 --- a/t/t5561-http-backend.sh +++ b/

Re: [PATCH] doc: git-htmldocs.googlecode.com is no more

2016-06-22 Thread Eric Wong
Jonathan Nieder wrote: > I'd rather use an up-to-date https link for the rendered > documentation, but I wasn't able to find one. According to the 'todo' > branch, prebuilt documentation is pushed to > > 1. https://kernel.googlesource.com/pub/scm/git/git-htmldocs > 2. git://repo.or.cz/git-html

Re: [PATCH] doc: git-htmldocs.googlecode.com is no more

2016-06-22 Thread Eric Wong
Junio C Hamano wrote: > On Wed, Jun 22, 2016 at 12:00 PM, Eric Wong wrote: > > > > Just wondering, who updates > > https://kernel.org/pub/software/scm/git/docs/ > > and why hasn't it been updated in a while? > > (currently it says Last updated 2015-06-06

Re: may be bug in svn fetch no-follow-parent

2016-06-22 Thread Eric Wong
svk::parents can be expensive and pointless. Reported-by: Александр Овчинников http://mid.gmane.org/4094761466408...@web24o.yandex.ru Signed-off-by: Eric Wong --- The following changes since commit ab7797dbe95fff38d9265869ea367020046db118: Start the post-2.9 cycle (2016-06-20 11:06:

Re: git-svn aborts with "Use of uninitialized value $u" when a non-svn-backed branch is present in remote

2016-06-24 Thread Eric Wong
Jacob Godserv wrote: > On Tue, Sep 22, 2015 at 2:48 PM, Jacob Godserv wrote: > > I found a specific case in which git-svn improperly aborts: > > > > 1. I created a git-svn repository, named "git-svn repo", by cloned an > > svn repository via the git-svn tool. > > 2. I created a normal git reposit

Re: git-svn aborts with "Use of uninitialized value $u" when a non-svn-backed branch is present in remote

2016-06-24 Thread Eric Wong
Please don't drop Cc:, re-adding git@vger and Christian Jacob Godserv wrote: > > Christian (Cc-ed) also noticed the problem a few weeks ago > > and took a more drastic approach by having git-svn die > > instead of warning: > > http://mid.gmane.org/1462604323-18545-1-git-send-email-chrisc...@tuxfa

[RFC] gc: correct gc.autoPackLimit documentation

2016-06-24 Thread Eric Wong
- return gc_auto_pack_limit <= cnt; + return gc_auto_pack_limit < cnt; However, changing gc itself at this time may cause problems for people who are already using gc.autoPackLimit=2 and expect bitmaps to work for them. Signed-off-by: Eric Wong --- Documentation/config.txt |

Re: [RFC] gc: correct gc.autoPackLimit documentation

2016-06-24 Thread Eric Wong
Jeff King wrote: > On Sat, Jun 25, 2016 at 01:14:50AM +, Eric Wong wrote: > > > I'm not sure if this is the best approach, or if changing > > too_many_packs can be done without causing problems for > > hosts of big repos. > > > > --

[PATCH] gc: fix off-by-one error with gc.autoPackLimit

2016-06-24 Thread Eric Wong
This matches the documentation and allows gc.autoPackLimit=1 to maintain a single pack without attempting a repack on every "git gc --auto" invocation. Signed-off-by: Eric Wong --- builtin/gc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/builtin/gc.c b/builtin/

Re: [PATCH v12 04/20] index-helper: new daemon for caching index and related stuff

2016-06-26 Thread Eric Wong
David Turner wrote: > On 06/25/2016 10:33 AM, Duy Nguyen wrote: > >>+ /* > >>+* Our connection to the client is blocking since a client > >>+* can always be killed by SIGINT or similar. > >>+*/ > >>+ set_socket_blocking_fl

[PATCH 0/2] wrapper: xread/xwrite fixes for non-blocking FDs

2016-06-26 Thread Eric Wong
pied the branch from xread into xwrite without the "continue" and was greeted with a failed clone. Eric Wong (2): xread: retry after poll on EAGAIN/EWOULDBLOCK xwrite: poll on non-blocking FDs wrapper.c | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(

[PATCH 2/2] xwrite: poll on non-blocking FDs

2016-06-26 Thread Eric Wong
-pack. Followup-to: 1079c4be0b720 ("xread: poll on non blocking fds") Signed-off-by: Eric Wong --- wrapper.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/wrapper.c b/wrapper.c index f1155d0..d973f86 100644 --- a/wrapper.c +++ b/wrap

[PATCH 1/2] xread: retry after poll on EAGAIN/EWOULDBLOCK

2016-06-26 Thread Eric Wong
We should continue to loop after EAGAIN/EWOULDBLOCK as the intent of xread is to read as much as possible until an EOF or real error occurs. Fixes: 1079c4be0b720 ("xread: poll on non blocking fds") Signed-off-by: Eric Wong --- wrapper.c | 1 + 1 file changed, 1 insertion(+) di

Re: [PATCH v12 04/20] index-helper: new daemon for caching index and related stuff

2016-06-26 Thread Eric Wong
David Turner wrote: > On 06/26/2016 04:53 AM, Eric Wong wrote: > >David Turner wrote: > >>On 06/25/2016 10:33 AM, Duy Nguyen wrote: > >>>>+ /* > >>>>+* Our connection to the client is blocking since a client > >&

[PATCHv2 1/2] xread: retry after poll on EAGAIN/EWOULDBLOCK

2016-06-26 Thread Eric Wong
Jeff King wrote: > On Sun, Jun 26, 2016 at 11:21:11PM +, Eric Wong wrote: > > > We should continue to loop after EAGAIN/EWOULDBLOCK as the > > intent of xread is to read as much as possible until an > > EOF or real error occurs. > > BTW, a minor nit here. xrea

Re: [PATCH 1/2] xread: retry after poll on EAGAIN/EWOULDBLOCK

2016-06-27 Thread Eric Wong
the missing "continue". Maybe the following optional patch on top of this series improves readability: --8< Subject: [PATCH 3/2] hoist out io_wait function for xread and xwrite At least for me, this improves the readability of xread and xwrite; hopefully allowing

Re: [PATCH 1/2] xread: retry after poll on EAGAIN/EWOULDBLOCK

2016-06-27 Thread Eric Wong
Jeff King wrote: > On Mon, Jun 27, 2016 at 05:49:48PM -0400, Jeff King wrote: > > > So in general I would say that handing non-blocking descriptors to git > > is not safe. Indeed. This also makes me wonder if our output to stdout/stderr suffer from the same theoretical problems if given non-blo

Re: git svn clone segmentation faul issue

2016-06-28 Thread Eric Wong
ioannis.kap...@rbs.com wrote: > Fortunately, a patch has already been submitted to subversion > with (github) revision > a074af86c8764404b28ce99d0bedcb668a321408 (at > https://github.com/apache/subversion/commit/a074af86c8764404b28ce99d0bedcb668a321408 > ) on the trunk to handle this and a couple o

Re: [RFC/PATCH v2 00/10] Add initial experimental external ODB support

2016-06-29 Thread Eric Wong
Christian Couder wrote: > Design discussion about performance > ~~~ > > Yeah, it is not efficient to fork/exec a command to just read or write > one object to or from the external ODB. Batch calls and/or using a > daemon and/or RPC should be used instead to be able

Re: [PATCH 5/9] merge-recursive: avoid returning a wholesale struct

2016-07-01 Thread Eric Wong
Johannes Schindelin wrote: > P.S.: If it is not too much of a problem, may I ask you to simply delete > remainders of my patches when replying and not commenting on them? I just > deleted 226 lines after verifying that you really did not respond to any > part of it in the unhelpful Alpine client (

Re: [PATCHv2 3/4] push: accept push options

2016-07-02 Thread Eric Wong
Stefan Beller wrote: > @@ -513,6 +531,17 @@ int send_pack(struct send_pack_args *args, > strbuf_release(&req_buf); > strbuf_release(&cap_buf); > > + if (use_push_options) { > + struct string_list_item *item; > + struct strbuf sb = STRBUF_INIT; > + > +

[PATCH] git-svn: warn instead of dying when commit data is missing

2016-07-02 Thread Eric Wong
Christian Couder wrote: > On Fri, Jun 24, 2016 at 10:06 PM, Eric Wong wrote: > > Jacob Godserv wrote: > >> > Christian (Cc-ed) also noticed the problem a few weeks ago > >> > and took a more drastic approach by having git-svn die > >> > instead of wa

Re: [PATCH] git-svn: clone: Fail on missing url argument

2016-07-02 Thread Eric Wong
he '* ' and space prefix from the version I've applied since it's not the convention around here. > Signed-off-by: Christopher Layne Signed-off-by: Eric Wong And pushed to "master" of git://bogomips.org/git-svn (I'll request for Junio to pull with

[PATCH] http-walker: remove unused parameter from fetch_object

2016-07-05 Thread Eric Wong
This parameter has not been used since commit 1d389ab65dc6 ("Add support for parallel HTTP transfers") back in 2005 Signed-off-by: Eric Wong --- I might followup in a few days/weeks with further updates in this area, but at least should be trivially correct :) http-walker.c | 4 ++

Re: What's cooking in git.git (Jul 2016, #03; Fri, 8)

2016-07-09 Thread Eric Wong
is missing (2016-07-09 22:53:54 +) Christopher Layne (1): git-svn: clone: Fail on missing url argument Eric Wong (1): git-svn: warn instead of dying when commit data is missing git-svn.perl| 5 - perl/Git/SVN.

Re: Over-/underquoting, was Re: [PATCH] revert: clarify seemingly bogus OPT_END repetition

2016-07-09 Thread Eric Wong
Michael J Gruber wrote: > 2016-07-06 22:15 GMT+02:00 Jacob Keller : > > On Wed, Jul 6, 2016 at 6:16 AM, Johannes Schindelin > > wrote: > ... > >>> It is not unheard of that a MUA can collapse and expand properly quoted > >>> parts on request... > >> > >> Sure. Show me some kick-ass, scriptable ma

Re: What's cooking in git.git (Jul 2016, #03; Fri, 8)

2016-07-09 Thread Eric Wong
Junio C Hamano wrote: > * sb/submodule-parallel-fetch (2016-06-27) 2 commits > (merged to 'next' on 2016-07-06 at de5fd35) > + xwrite: poll on non-blocking FDs > + xread: retry after poll on EAGAIN/EWOULDBLOCK > > Fix a recently introduced codepaths that are involved in parallel > submodule

[ANNOUNCE] more archives of this list

2016-07-09 Thread Eric Wong
Very much a work-in-progress, but NNTP and HTTP/HTTPS sorta work based on stuff that is on gmane and stuff I'm accumulating by being a subscriber. The first two Tor hidden service onions are actually on better hardware than the non-hidden public-inbox.org one: nntp://hjrcffqmbrq6wope.onion/inbox.

Re: What's cooking in git.git (Jul 2016, #03; Fri, 8)

2016-07-09 Thread Eric Wong
Jeff King wrote: > On Sat, Jul 09, 2016 at 11:45:18PM +, Eric Wong wrote: > > Junio C Hamano wrote: > > > * sb/submodule-parallel-fetch (2016-06-27) 2 commits > > > (merged to 'next' on 2016-07-06 at de5fd35) > > > + xwrite: poll on non-bl

Re: [ANNOUNCE] more archives of this list

2016-07-09 Thread Eric Wong
Eric Wong wrote: > https://public-inbox.org/.temp/git.vger.kernel.org-6c38c917e55c.gz > (362M) > > git init --bare mirror.git > curl $FAST_EXPORT_GZ_URL | git --git-dir=mirror.git fast-import Oops, that is missing zcat: curl $FAST_EXPORT_GZ_U

[PATCH 3/2] hoist out handle_nonblock function for xread and xwrite

2016-07-10 Thread Eric Wong
At least for me, this improves the readability of xread and xwrite; hopefully allowing missing "continue" statements to be spotted more easily. Signed-off-by: Eric Wong Signed-off-by: Jeff King --- Jeff King wrote: > On Sun, Jul 10, 2016 at 03:47:36AM +0000, Eric Wong wrote:

[PATCH] config.mak.uname: define NEEDS_LIBRT under Linux, for now

2016-07-10 Thread Eric Wong
x27;t think this will introduce new breakage for users of alternative libc implementations. Signed-off-by: Eric Wong --- config.mak.uname | 2 ++ 1 file changed, 2 insertions(+) diff --git a/config.mak.uname b/config.mak.uname index a88f139..22958a8 100644 --- a/config.mak.uname +++ b/

[PATCH 2/3] http: avoid disconnecting on 404s for loose objects

2016-07-11 Thread Eric Wong
404s are common when fetching loose objects on static HTTP servers, and reestablishing a connection for every single 404 adds additional latency. Signed-off-by: Eric Wong --- http-walker.c | 9 + http.c| 16 ++-- 2 files changed, 23 insertions(+), 2 deletions

[PATCH 3/3] http-walker: reduce O(n) ops with doubly-linked list

2016-07-11 Thread Eric Wong
additional pointer per object request, but this is offset by reduced overhead on queue operations leading to improved performance and shorter queue depths. Signed-off-by: Eric Wong --- http-walker.c | 42 ++- list.h| 164 +++

[PATCH 1/3] http-walker: remove unused parameter from fetch_object

2016-07-11 Thread Eric Wong
This parameter has not been used since commit 1d389ab65dc6 ("Add support for parallel HTTP transfers") back in 2005 Signed-off-by: Eric Wong --- http-walker.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/http-walker.c b/http-walker.c index 2c721f0..9f28

[RFC 0/3] dumb HTTP transport speedups

2016-07-11 Thread Eric Wong
list (2016-07-11 20:25:51 +) ---- Eric Wong (3): http-walker: remove unused parameter from fetch_object http: avoid disconnecting on 404s for loose objects http-walker: reduce O(n) ops with doubly-linked l

[REJECT 4/3] http-walker: use hashmap to reduce list scan

2016-07-11 Thread Eric Wong
track of all live object requests in O(1) average time. Signed-off-by: Eric Wong --- http-walker.c | 35 +++ 1 file changed, 27 insertions(+), 8 deletions(-) diff --git a/http-walker.c b/http-walker.c index 0b24255..8d27707 100644 --- a/http-walker.c +++ b/http-wal

Re: [ANNOUNCE] Git v2.9.1

2016-07-11 Thread Eric Wong
Jeff King wrote: > Otherwise, we'll have to skip the test, perhaps with something like the > patch below. I suspect the problem is actually the size of "unsigned > long", not time_t, as we use that internally for a bunch of time > computation. We should probably be using int64_t for time calculat

Re: Plugin mechanism(s) for Git?

2016-07-15 Thread Eric Wong
Konstantin Khomoutov wrote: > Ben Peart wrote: > > > Lars Schneider wrote: > > > > > > We could dynamically load libraries but this would force us to > > > freeze the ABI as mentioned by Duy: > > > http://article.gmane.org/gmane.comp.version-control.git/298463 > > > > > > > I wouldn’t be too q

Re: What's cooking in git.git (Jul 2016, #05; Wed, 13)

2016-07-16 Thread Eric Wong
Lars Schneider wrote: > > On 13 Jul 2016, at 18:56, Junio C Hamano wrote: > > * ew/http-walker (2016-07-12) 3 commits > > - http-walker: reduce O(n) ops with doubly-linked list > > - http: avoid disconnecting on 404s for loose objects > > - http-walker: remove unused parameter from fetch_object >

[PATCH] list: avoid incompatibility with *BSD sys/queue.h

2016-07-16 Thread Eric Wong
Eric Wong wrote: > Lars Schneider wrote: > > It looks like as if this topic breaks the OS X build because > > it defines LIST_HEAD. LIST_HEAD is already defined in > > /usr/include/sys/queue.h. > > Oops, I suppose GIT_LIST_HEAD is an acceptable name? > (look

Re: [PATCH] list: avoid incompatibility with *BSD sys/queue.h

2016-07-17 Thread Eric Wong
Eric Sunshine wrote: > On Sat, Jul 16, 2016 at 8:25 PM, Eric Wong wrote: > > Eric Wong wrote: > >> I also wonder where we use sys/queue.h, since I use > >> LIST_HEAD from ccan/list/list.h in a different project > >> without conflicts... > > > >

Re: git-svn dies all the time

2016-07-17 Thread Eric Wong
Alexandre Bique wrote: > Hi, > > I did by mistake report the bug here: > > https://github.com/git/git-scm.com/issues/807#issuecomment-233200404 > > In short this is a backtrace of git svn rebase crashing in perl, and > likely because of an out of memory issue. It crashed on my laptop but > not

[PATCH] daemon: ignore ENOTSOCK from setsockopt

2016-07-17 Thread Eric Wong
In inetd mode, we are not guaranteed stdin or stdout is a socket; callers could filter the data through a pipe or be testing with regular files. This prevents t5802 from polluting syslog. Signed-off-by: Eric Wong --- daemon.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff

[PATCH] test-lib: stricter unzip(1) check

2016-07-17 Thread Eric Wong
/usr/local/bin/unzip (via "pkg install unzip") to pass t5003. This Info-ZIP version exits with "0" when given "-v", so limit the prereq to only versions which return 0 on "-v". [1] https://www.freebsd.org/cgi/man.cgi?query=unzip&sektion=1&manpath=Fr

[PATCH] pager: disable color when pager is "more"

2016-07-18 Thread Eric Wong
on common GNU/Linux systems. So take the safe route and assume anybody still using more(1) today can live with monochrome output, but acknowledge 'R' in the MORE environment variable if it was set by the user. Signed-off-by: Eric Wong --- environment.c | 2 +- pager.c | 11

[PATCH] configure.ac: stronger test for pthread linkage

2016-07-18 Thread Eric Wong
We need to test linkage of pthread_create and pthread_join, as pthread_mutex_* and pthread_key_* functions do not need extra linkage under FreeBSD 10.3, leading to a false-positive of the empty case. Signed-off-by: Eric Wong --- configure.ac | 5 + 1 file changed, 5 insertions(+) diff

Re: [PATCH] test-lib: stricter unzip(1) check

2016-07-18 Thread Eric Wong
Junio C Hamano wrote: > +test_lazy_prereq UNZIP_AUTOTEXT ' > + ( > + mkdir unzip-autotext && > + cd unzip-autotext > + "$GIT_UNZIP" -a "$TEST_DIRECTORY"/t5003/infozip-text.zip && > + test -f text > + ) /usr/bin/unzip actually takes -a on Fre

Re: [PATCH] test-lib: stricter unzip(1) check

2016-07-18 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > Junio C Hamano wrote: > >> +test_lazy_prereq UNZIP_AUTOTEXT ' > >> + ( > >> + mkdir unzip-autotext && > >> + cd unzip-autotext > >> + "$GIT_UNZIP

t7063 failure on FreeBSD 10.3 i386/amd64

2016-07-18 Thread Eric Wong
Not sure what's going on, below is the relevant output when run with -i -v --tee (the rest succeeds without -i): ok 26 - untracked cache correct after status expecting success: avoid_racy && : >../trace && GIT_TRACE_UNTRACKED_STATS="$TRASH_DIRECTORY/trace" \ git s

Re: t7063 failure on FreeBSD 10.3 i386/amd64

2016-07-18 Thread Eric Wong
Oops, forgot to Cc some folks who worked on this :x Filesystem is ufs and it fails regardless of whether soft-updates is enabled or not. Eric Wong wrote: > Not sure what's going on, below is the relevant output when > run with -i -v --tee (the rest succeeds without -i): > >

Re: [PATCH] pager: disable color when pager is "more"

2016-07-18 Thread Eric Wong
Junio C Hamano wrote: > Jeff King writes: > > On Mon, Jul 18, 2016 at 09:19:07AM +0000, Eric Wong wrote: > >> Johannes Schindelin wrote: > >> > On Sun, 17 Jul 2016, n...@dad.org wrote: > >> > > 'git diff' outputs escape characters which clu

[PATCH] git-svn: document svn.authorsProg in config

2016-07-19 Thread Eric Wong
This has always been supported since we read config variables based on the command-line option parser. Document it explicitly since users usually want to maintain the same program across invocations. Signed-off-by: Eric Wong --- Pushed to master of bogomips.org/git-svn.git, but I might have

[RFC] git-svn: allow --version to work anywhere

2016-07-19 Thread Eric Wong
Checking the version of the installed SVN libraries should not require a git repository at all. This matches the behavior of "git --version". Add a test for "git svn help" for the same behavior while we're at it, too. Signed-off-by: Eric Wong --- I'm hoping

[PATCH] config.mak.uname: set PERL_PATH for FreeBSD 5.0+

2016-07-19 Thread Eric Wong
Perl has not been part of the base system since FreeBSD 5.0: https://www.freebsd.org/releases/5.0R/relnotes-i386.html Signed-off-by: Eric Wong --- Does anybody still run git on FreeBSD 4.x or earlier? 4.11 was released a few months before git in 2005: https

Re: t7063 failure on FreeBSD 10.3 i386/amd64

2016-07-19 Thread Eric Wong
Duy Nguyen wrote: > On Tue, Jul 19, 2016 at 12:54 AM, Eric Wong wrote: > > Oops, forgot to Cc some folks who worked on this :x > > > > Filesystem is ufs and it fails regardless of whether > > soft-updates is enabled or not. > > Nothing stands out to my eyes, so

Re: [PATCH] config.mak.uname: set PERL_PATH for FreeBSD 5.0+

2016-07-20 Thread Eric Wong
Johannes Schindelin wrote: > Hi Eric, > > On Wed, 20 Jul 2016, Eric Wong wrote: > > > diff --git a/config.mak.uname b/config.mak.uname > > index a88f139..6c29545 100644 > > --- a/config.mak.uname > > +++ b/config.mak.uname > > @@

Re: [PATCH] test-lib: on FreeBSD, look for unzip(1) in /usr/local/bin/

2016-07-21 Thread Eric Wong
Johannes Schindelin wrote: > The common work-around is to install Info-Zip on FreeBSD, into > /usr/local/bin/. > > Signed-off-by: Johannes Schindelin Thanks, t5003 now works out-of-the-box. Tested with Info-ZIP unzip installed and uninstalled. Tested-by: Eric Wong -- To unsubscri

Re: [PATCH ew/daemon-socket-keepalive] Windows: add missing definition of ENOTSOCK

2016-07-22 Thread Eric Wong
Johannes Sixt wrote: > The previous commit introduced the first use of ENOTSOCK. This macro is > not available on Windows. Define it as WSAENOTSOCK because that is the > corresponding error value reported by the Windows versions of socket > functions. Thanks. I thought compat/poll/poll.c alread

[PATCH] git-svn: allow --version to work anywhere

2016-07-22 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > I'm hoping "cd /" in the test will always succeed; > > but I suppose non-*nix systems might fail, here. > > How about digging a few levels of directory hierarchy, exporting > GIT_CEILING_DIRECTORIES s

[PATCH] format-patch: escape "From " lines recognized by mailsplit

2016-07-22 Thread Eric Wong
ref: https://public-inbox.org/git/20160606230248.ga15...@dcvr.yhbt.net/T/#u Signed-off-by: Eric Wong --- builtin/mailsplit.c | 32 +--- mailinfo.c | 31 +++ mailinfo.h | 1 + pretty.c| 16 ++

[PATCH 0/2] fix git-svn HTTP tests under Apache 2.4

2016-07-22 Thread Eric Wong
: migrate tests to use lib-httpd (2016-07-23 03:31:21 +) Eric Wong (1): git svn: migrate tests to use lib-httpd Michael J Gruber (1): t/t91*: do not say how to avoid the tests t/lib-git-svn.sh

[PATCH 2/2] git svn: migrate tests to use lib-httpd

2016-07-22 Thread Eric Wong
2.2 and 2.4 on Debian 7.x (wheezy) and 8.x (jessie), respectively. Cc: Clemens Buchacher Cc: Michael J Gruber Signed-off-by: Eric Wong --- t/lib-git-svn.sh | 91 +-- t/lib-httpd.sh| 8 ++- t/lib-httpd

[PATCH 1/2] t/t91*: do not say how to avoid the tests

2016-07-22 Thread Eric Wong
nces. Signed-off-by: Michael J Gruber Signed-off-by: Eric Wong --- t/t9100-git-svn-basic.sh | 2 -- t/t9158-git-svn-mergeinfo.sh | 2 -- t/t9160-git-svn-preserve-empty-dirs.sh | 1 - 3 files changed, 5 deletions(-) diff --git a/t/t9100-git-svn-basic.sh b/t/t9100-git-svn-ba

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

2016-07-23 Thread Eric Wong
Jakub Narębski wrote: > W dniu 2016-07-22 o 17:49, larsxschnei...@gmail.com pisze: > > +use strict; > > +use warnings; > > +use autodie; > > autodie? "set -e" for Perl (man autodie) It's been a part of Perl for ages, but I've never used it myself, either; I suppose it's fine for tests... > > +

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

2016-07-23 Thread Eric Wong
larsxschnei...@gmail.com wrote: > Please note that the protocol filters do not support stream processing > with this implemenatation because the filter needs to know the length of > the result in advance. A protocol version 2 could address this in a > future patch. Would it be prudent to reuse pkt

Re: [PATCH] format-patch: escape "From " lines recognized by mailsplit

2016-07-23 Thread Eric Wong
ges up to 4f769f1799db11f135948bf517f2d8d864fa778f: format-patch: escape "From " lines recognized by mailsplit (2016-07-23 21:38:40 +) ---- Eric Wong (2): mailinfo: extract is_from_line from mailsplit format-patch: escape "

[PATCH 1/2] mailinfo: extract is_from_line from mailsplit

2016-07-23 Thread Eric Wong
We will be reusing is_from_line for quoting format-patch output in the next commit. Suggested-by: Johannes Schindelin Signed-off-by: Eric Wong --- builtin/mailsplit.c | 32 +--- mailinfo.c | 31 +++ mailinfo.h | 1 + 3

[PATCH 2/2] format-patch: escape "From " lines recognized by mailsplit

2016-07-23 Thread Eric Wong
ref: https://public-inbox.org/git/20160606230248.ga15...@dcvr.yhbt.net/T/#u Signed-off-by: Eric Wong --- pretty.c| 16 +--- t/t4014-format-patch.sh | 14 ++ 2 files changed, 27 insertions(+), 3 deletions(-) diff --git a/pretty.c b/pretty.c index 9fa42c2.

Re: [PATCH] format-patch: escape "From " lines recognized by mailsplit

2016-07-24 Thread Eric Wong
Junio C Hamano wrote: > As a tool to produce mbox file, quoting like this in format-patch > output may make sense, I would think, but shouldn't send-email undo > this when sending individual patches? Yes, that sounds like a good idea. Thanks. Will followup in a day or two. -- To unsubscribe from

Re: [RFC 0/3] dumb HTTP transport speedups

2016-07-24 Thread Eric Wong
Jakub Narębski wrote: > W dniu 2016-07-11 o 22:51, Eric Wong pisze: > > > TL;DR: dumb HTTP clone from a certain badly-packed repo goes from > > ~2 hours to ~30 min memory usage drops from 2G to 360M > > > > > > I hadn't packed the public repo at https:/

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

2016-07-25 Thread Eric Wong
Lars Schneider wrote: > On 23 Jul 2016, at 10:14, Eric Wong wrote: > > larsxschnei...@gmail.com wrote: > >> +static struct cmd2process *start_protocol_filter(const char *cmd) > >> +{ > >> + int ret = 1; > >> + struct cmd2process *entry = NULL;

Re: [PATCH] format-patch: escape "From " lines recognized by mailsplit

2016-07-25 Thread Eric Wong
Junio C Hamano wrote: > Junio C Hamano writes: > > Eric Wong writes: > > > >> Users have mistakenly copied "From " lines into commit messages > >> in the past, and will certainly make the same mistakes in the > >> future. Since not everyo

Re: [PATCH] config.mak.uname: correct perl path on FreeBSD

2016-07-25 Thread Eric Wong
Junio C Hamano wrote: > Duy Nguyen writes: > > > On Mon, Jul 25, 2016 at 6:56 PM, Junio C Hamano wrote: > >> On Mon, Jul 25, 2016 at 9:21 AM, Nguyễn Thái Ngọc Duy > >> wrote: > >>> It looks the the symlink /usr/bin/perl (to /usr/local/bin/perl) has > >>> been removed at least on FreeBSD 10.3.

Re: [PATCH] format-patch: escape "From " lines recognized by mailsplit

2016-07-25 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > >> Also, doesn't it break "git rebase" (non-interactive), or anything > >> that internally runs format-patch to individual files and then runs > >> am on each of them, anything that knows that each out

Re: [PATCH] config.mak.uname: correct perl path on FreeBSD

2016-07-25 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > Junio C Hamano wrote: > >> Duy Nguyen writes: > >> > On Mon, Jul 25, 2016 at 6:56 PM, Junio C Hamano > >> > wrote: > >> >> On Mon, Jul 25, 2016 at 9:21 AM, Nguyễn Thái Ngọc Duy > >

Re: What's cooking in git.git (Jul 2016, #07; Mon, 25)

2016-07-26 Thread Eric Wong
Lars Schneider wrote: > On 26 Jul 2016, at 00:50, Junio C Hamano wrote: > > > > * ew/git-svn-http-tests (2016-07-25) 2 commits > > - git svn: migrate tests to use lib-httpd > > - t/t91*: do not say how to avoid the tests > > > > Reuse the lib-httpd test infrastructure when testing the subversio

Re: [PATCH v2 5/5] convert: add filter..process option

2016-07-27 Thread Eric Wong
larsxschnei...@gmail.com wrote: > +static off_t multi_packet_read(struct strbuf *sb, const int fd, const size_t > size) I'm no expert in C, but this might be const-correctness taken too far. I think basing this on the read(2) prototype is less surprising: static ssize_t multi_packet_read(int

Re: Alternatives to mid.gmane.org?

2016-07-28 Thread Eric Wong
Duy Nguyen wrote: > On Thu, Jul 28, 2016 at 11:11 AM, Lars Schneider > wrote: > > Hi, > > > > gmane is down At least the following should work in case public-inbox fails: https://mid.mail-archive.com/%s https://marc.info/?i=%s public-inbox falls back to them on missing MIDs, al

Re: [ANNOUNCE] more archives of this list

2016-07-28 Thread Eric Wong
Eric Wong wrote: > Code is AGPL-3.0+: git clone https://public-inbox.org/ > > > Additional mirrors or forks (perhaps different UIs) are very welcome, Btw, it's possible to do quote highlighting with user-side CSS: https://public-inbox.org/meta/20160709-user-side-css-example@1

Re: Alternatives to mid.gmane.org?

2016-07-28 Thread Eric Wong
Duy Nguyen wrote: > I read this and thought "temporarily" but apparently it's not [1]. A > lot of our links in the mail archive are gmane's :( > > [1] https://lars.ingebrigtsen.no/2016/07/28/the-end-of-gmane/ I may not have time to integrate this extensibly into the public-inbox search engine to

Re: [PATCH] git-svn: allow --version to work anywhere

2016-07-28 Thread Eric Wong
Junio C Hamano wrote: > Subject: [PATCH] t9100: portability fix > > Do not say "export VAR=VAL"; "VAR=VAL && export VAR" is always more > portable. Oops, sorry I should've caught that :x -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.

Re: [PATCH] t7063: work around FreeBSD's lazy mtime update feature

2016-07-30 Thread Eric Wong
look further in FreeBSD source code, this > flag is now called IN_LAZYMOD. I can see it's effective in ext2 and > ufs. zfs is questionable. > > [1] 660e6408e6df99a20dacb070c5e7f9739efdf96d > [2] git://github.com/freebsd/freebsd.git > [3] https://bugs.freebsd.org/bugzill

Re: [PATCH] t7063: work around FreeBSD's lazy mtime update feature

2016-07-30 Thread Eric Wong
Eric Wong wrote: > Nguyễn Thái Ngọc Duy wrote: > > +test_expect_success FREEBSD 'Work around lazy mtime update' ' > > + ls -ld . >/dev/null > > +' > > stat . >/dev/null If there's some older FreeBSD w/o stat(1); "test -x .

[PATCH 0/2] add PAGER_ENV to build and core.pagerEnv to config

2016-07-31 Thread Eric Wong
:51:42 +) Eric Wong (1): pager: implement core.pagerEnv in config Junio C Hamano (1): pager: move pager-specific setup into the build Documentation/config.txt | 7 +++ Makefile | 19

[PATCH 2/2] pager: implement core.pagerEnv in config

2016-07-31 Thread Eric Wong
This allows overriding the build-time PAGER_ENV variable at run-time. Inspired by part 1 of an idea from Kyle J. McKay at: https://public-inbox.org/git/62db6def-8b39-4481-ba06-245bf4523...@gmail.com/ Signed-off-by: Eric Wong --- Documentation/config.txt | 7 +++ pager.c

[PATCH 1/2] pager: move pager-specific setup into the build

2016-07-31 Thread Eric Wong
to override the build-time environment in the next commit. Originally-from: https://public-inbox.org/git/xmqq61piw4yf@gitster.dls.corp.google.com/ Signed-off-by: Eric Wong --- Makefile | 19 +-- config.mak.uname | 1 + git-sh-setup.sh | 8 +--- pager.c

Re: [PATCH 1/2] pager: move pager-specific setup into the build

2016-08-01 Thread Eric Wong
"brian m. carlson" wrote: > On Mon, Aug 01, 2016 at 01:05:56AM +0000, Eric Wong wrote: > > + while (*cp && *cp == ' ') > > + cp++; > > So it looks like this function splits on spaces but doesn't provide any > e

Re: [ANNOUNCE] git-series: track changes to a patch series over time

2016-08-01 Thread Eric Wong
Christian Couder wrote: > On Fri, Jul 29, 2016 at 12:10 PM, Richard Ipsum > wrote: > > On Thu, Jul 28, 2016 at 11:40:55PM -0700, Josh Triplett wrote: > > [snip] > >> > >> I'd welcome any feedback, whether on the interface and workflow, the > >> internals and collaboration, ideas on presenting dif

Re: [ANNOUNCE] git-series: track changes to a patch series over time

2016-08-01 Thread Eric Wong
Josh Triplett wrote: > On Mon, Aug 01, 2016 at 07:55:54AM +, Eric Wong wrote: > > Christian Couder wrote: > > > On Fri, Jul 29, 2016 at 12:10 PM, Richard Ipsum > > > wrote: > > > > On Thu, Jul 28, 2016 at 11:40:55PM -0700, Josh Triplett wrote: >

  1   2   3   4   5   6   7   8   9   10   >