Re: [PATCH] config.c: fix potential number truncation in git_parse_signed()

2016-07-08 Thread Duy Nguyen
On Wed, Jul 6, 2016 at 9:33 PM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> clang -Wabsolute-value on IA-32 architecture complains that "absolute >> value function 'labs' given an argument of type 'intmax_t' (aka 'long >> long') but has parameter of type 'long' which may cause trun

Re: [PATCH v13 11/20] index-helper: use watchman to avoid refreshing index with lstat()

2016-07-08 Thread Duy Nguyen
On Wed, Jul 06, 2016 at 04:54:00PM +, Ben Peart wrote: > Duy Nguyen gmail.com> writes: > > > > > First step would be enabling that because besides directory > > traversing, this code does a lot of string processing that's hopefully > > eliminated by untra

Re: [PATCH v13 11/20] index-helper: use watchman to avoid refreshing index with lstat()

2016-07-08 Thread Duy Nguyen
BTW just for me to have some perspective, roughly how many directories and files are there in the worktree of this repo? -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/maj

Re: [PATCH v2 2/2] cache-tree: do not generate empty trees as a result of all i-t-a subentries

2016-07-08 Thread Duy Nguyen
On Fri, Jul 8, 2016 at 5:53 PM, Junio C Hamano wrote: > Duy Nguyen writes: > >> Yeah that's better. So the squash patch is something like this > > Rather... > >> diff --git a/t/t2203-add-intent.sh b/t/t2203-add-intent.sh >> index a19f06b..80880b7 100755 >

Re: git branch doesn't allow me to forcibly delete branch which was checked out in a now-deleted worktree dir

2016-07-08 Thread Duy Nguyen
On Thu, Jul 7, 2016 at 8:44 PM, Erik Johnson wrote: > % git branch -D archive-extracted-xz > error: Cannot delete branch 'archive-extracted-xz' checked out at > '/home/erik/git/salt/archive-extracted-xz' This is from commit f292244 (branch -d: refuse deleting a branch which is currently checked o

Re: gc and repack ignore .git/*HEAD when checking reachability

2016-07-09 Thread Duy Nguyen
On Sat, Jul 9, 2016 at 4:09 PM, Josh Triplett wrote: > On Sat, Jul 09, 2016 at 09:35:24AM +0200, Johannes Schindelin wrote: >> On Fri, 8 Jul 2016, Junio C Hamano wrote: >> > Josh Triplett writes: >> > >> > > That sounds reasonable. And if they *do* end up taking any time to >> > > traverse, it's

Re: [PATCH 0/5] Number truncation with 4+ GB files on 32-bit systems

2016-07-10 Thread Duy Nguyen
On Tue, Jul 5, 2016 at 7:05 PM, Nguyễn Thái Ngọc Duy wrote: > Most of the rest seems harmless, except for the local variable "size" > in builtin/pack-objects.c:write_one(). I might send 6/5 for that one. This truncated "size" produces incorrect .idx file and makes everybody else fail to read the

Re: gc and repack ignore .git/*HEAD when checking reachability

2016-07-10 Thread Duy Nguyen
On Sun, Jul 10, 2016 at 12:59 PM, Johannes Schindelin wrote: >> >> Now, how about special-casing *just* these legacy files in gc: HEAD, >> >> FETCH_HEAD, MERGE_HEAD and CHERRY_PICK_HEAD? Any new transient refs should >> >> live in the refs/ namespace, which is already handled. >> > >> > That seems

Re: gc and repack ignore .git/*HEAD when checking reachability

2016-07-10 Thread Duy Nguyen
On Sun, Jul 10, 2016 at 4:16 PM, Johannes Schindelin wrote: >> No, the point is, refs subsystem needs to know which refs is per-repo, >> which is per-worktree. So far the rules are "everything under refs, >> except a few known exceptions, is per-repo" and "everything directly >> under $GIT_DIR is

Re: [PATCH 00/38] Virtualization of the refs API

2016-07-10 Thread Duy Nguyen
On Fri, Jun 3, 2016 at 11:03 PM, Michael Haggerty wrote: > Since the that ref-iterator [1] changes seem to have gotten a positive > reception, let's try to keep up the momentum. I hope I'm not > overloading the review pipeline... > > I think all of the groundwork is in place now to virtualize the

Re: [PATCH] pretty: add format specifiers: %gr, %gt, %gI, gi

2016-07-10 Thread Duy Nguyen
On Sun, Jul 10, 2016 at 4:26 PM, Theodore Ts'o wrote: > One other long-term thought. Maybe past a certain point, we should > just make it easy to get the data from git-log into a perl or pythons > script, where it becomes possible to do conditionals, more flexible > padding rules, etc. So some k

Re: [PATCH] Fix running tests with --valgrind

2016-07-11 Thread Duy Nguyen
On Mon, Jul 11, 2016 at 1:45 PM, Johannes Schindelin wrote: > We forgot to adjust this code path after moving the test helpers to > t/helper/. Oops. Yet it looks like the right thing to do. > > Signed-off-by: Johannes Schindelin > --- > Published-As: > https://github.com/dscho/git/releases/tag

Re: [RFC/PATCH 8/8] read-cache: unlink old sharedindex files

2016-07-11 Thread Duy Nguyen
On Mon, Jul 11, 2016 at 7:22 PM, Christian Couder wrote: > Everytime split index is turned on, it creates a "sharedindex." > file in the git directory. This makes sure that old sharedindex > files are removed after a new one has been created. Hmm it's one-way link, we don't know how many inde

Re: [RFC/PATCH 8/8] read-cache: unlink old sharedindex files

2016-07-12 Thread Duy Nguyen
On Tue, Jul 12, 2016 at 9:04 AM, Christian Couder wrote: > On Mon, Jul 11, 2016 at 8:27 PM, Duy Nguyen wrote: >> On Mon, Jul 11, 2016 at 7:22 PM, Christian Couder >> wrote: >>> Everytime split index is turned on, it creates a "sharedindex." >>>

Re: gc and repack ignore .git/*HEAD when checking reachability

2016-07-12 Thread Duy Nguyen
On Tue, Jul 12, 2016 at 5:26 PM, Jeff King wrote: > Likewise for other per-worktree items. If we used refs/MERGE_HEAD and > refs/worktree/foo/MERGE_HEAD, then you could access them independently > by using the fully qualified names. I'm not opposed to letting one worktree see everything, but this

Re: [RFC/PATCH 0/8] Add configuration options for split-index

2016-07-12 Thread Duy Nguyen
On Mon, Jul 11, 2016 at 7:22 PM, Christian Couder wrote: > Future work > ~~~ > > One thing that is probably missing is a mechanism to avoid having too > many changes accumulating in the (split) index while in split index > mode. The git-update-index documentation says: > > If split

Re: gc and repack ignore .git/*HEAD when checking reachability

2016-07-12 Thread Duy Nguyen
On Tue, Jul 12, 2016 at 5:51 PM, Jeff King wrote: > On Tue, Jul 12, 2016 at 05:46:12PM +0200, Duy Nguyen wrote: > >> I'm not opposed to letting one worktree see everything, but this move >> makes it harder to write new scripts (or new builtin commands, even) >> th

Re: [PATCH v14 00/21] index-helper/watchman

2016-07-12 Thread Duy Nguyen
Just thinking out loud. I've been thinking about this more about this. After the move from signal-based to unix socket for communication, we probably are better off with a simpler design than the shm-alike one we have now. What if we send everything over a socket or a pipe? Sending 500MB over a un

Re: [ANNOUNCE] Git v2.9.1

2016-07-12 Thread Duy Nguyen
On Tue, Jul 12, 2016 at 3:46 PM, Jeff King wrote: > On Tue, Jul 12, 2016 at 03:31:00PM +0200, Andreas Schwab wrote: > >> Johannes Schindelin writes: >> >> > Hi Andreas, >> > >> > On Tue, 12 Jul 2016, Andreas Schwab wrote: >> > >> >> Johannes Schindelin writes: >> >> >> >> >> PRIuMAX isn't compat

Re: [PATCH 0/5] Number truncation with 4+ GB files on 32-bit systems

2016-07-12 Thread Duy Nguyen
On Tue, Jul 12, 2016 at 10:38 PM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> Since I now could reproduce the problem that Christoph showed, I >> decided to send the good patches out. To sum up, we use "unsigned >> long" in some places related to file size. On 32-bit systems, it's

Re: [PATCH v3 1/4] test-lib.sh: introduce and use $_EMPTY_TREE

2016-07-13 Thread Duy Nguyen
On Tue, Jul 12, 2016 at 10:40 PM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> This is a special SHA1. Let's keep it at one place, easier to replace >> later when the hash change comes, easier to recognize. Start with an >> underscore to reduce the chances somebody may override it w

Re: [PATCH v3 4/4] cache-tree: do not generate empty trees as a result of all i-t-a subentries

2016-07-13 Thread Duy Nguyen
On Tue, Jul 12, 2016 at 10:49 PM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> diff --git a/cache-tree.c b/cache-tree.c >> index c2676e8..2d50640 100644 >> --- a/cache-tree.c >> +++ b/cache-tree.c >> @@ -380,6 +380,13 @@ static int update_one(struct cache_tree *it, >>

Re: gc and repack ignore .git/*HEAD when checking reachability

2016-07-13 Thread Duy Nguyen
On Wed, Jul 13, 2016 at 10:20 AM, Johannes Schindelin wrote: > Hi Duy, > > On Tue, 12 Jul 2016, Duy Nguyen wrote: > >> On Tue, Jul 12, 2016 at 5:51 PM, Jeff King wrote: >> > On Tue, Jul 12, 2016 at 05:46:12PM +0200, Duy Nguyen wrote: >> > >> >

Re: [RFC/PATCH 8/8] read-cache: unlink old sharedindex files

2016-07-13 Thread Duy Nguyen
On Tue, Jul 12, 2016 at 9:45 PM, Christian Couder wrote: > On Tue, Jul 12, 2016 at 5:12 PM, Duy Nguyen wrote: >> >> No. People could create an index file anywhere in theory. So you don't >> know how many index files there are. > > Maybe when an index file is creat

Re: [PATCH v3] config: add conditional include

2016-07-13 Thread Duy Nguyen
On Wed, Jul 13, 2016 at 9:21 AM, Matthieu Moy wrote: > Nguyễn Thái Ngọc Duy writes: > >> +`gitdir`:: >> + The environment variable `GIT_DIR` must match the following >> + pattern for files to be included. The pattern can contain >> + standard globbing wildcards and two additional ones

Re: What's cooking in git.git (Jul 2016, #05; Wed, 13)

2016-07-13 Thread Duy Nguyen
On Wed, Jul 13, 2016 at 6:56 PM, Junio C Hamano wrote: > * nd/pack-ofs-4gb-limit (2016-07-13) 7 commits > - fsck: use streaming interface for large blobs in pack > - pack-objects: do not truncate result in-pack object size on 32-bit systems > - index-pack: correct "offset" type in unpack_entry_

Re: Bug in index-helper/watchman?

2016-07-14 Thread Duy Nguyen
...and somehow I forgot to CC git@vger, g On Thu, Jul 14, 2016 at 5:14 PM, Duy Nguyen wrote: > Bug reports should always be in public (so people are aware of it) > unless it's security exploit of course. > > I have not read this mail yet, but I will in a couple of

Re: [PATCH v14 00/21] index-helper/watchman

2016-07-14 Thread Duy Nguyen
On Wed, Jul 13, 2016 at 11:59 PM, David Turner wrote: > On 07/12/2016 02:24 PM, Duy Nguyen wrote: >> >> Just thinking out loud. I've been thinking about this more about this. >> After the move from signal-based to unix socket for communication, we >> probably are

Re: [PATCH v14 00/21] index-helper/watchman

2016-07-14 Thread Duy Nguyen
Big typo.. On Thu, Jul 14, 2016 at 5:56 PM, Duy Nguyen wrote: > For giant-scale repos, you probably want something more efficient than > a script like this. And the good thing is you have freedom to do > whatever you want. You can run one daemon per repo, you can run one > daemo

Re: [PATCH v4] config: add conditional include

2016-07-14 Thread Duy Nguyen
On Thu, Jul 14, 2016 at 5:53 PM, Johannes Schindelin wrote: > Hi Duy, > > On Thu, 14 Jul 2016, Nguyễn Thái Ngọc Duy wrote: > >> Helped-by: Jeff King >> Signed-off-by: Nguyễn Thái Ngọc Duy > > This commit message is quite a bit short on details. Because it's fully documented in config.txt. > I

Re: gc and repack ignore .git/*HEAD when checking reachability

2016-07-15 Thread Duy Nguyen
On Wed, Jul 13, 2016 at 8:59 PM, Johannes Schindelin wrote: >> No. > > Oh? So you do not see that we are already heading into serious trouble > ourselves? I do see problems, that have solutions. But I have not yet seen that we are heading to a dead end. >> I prefer we have a single interface for

Re: Plugin mechanism(s) for Git?

2016-07-15 Thread Duy Nguyen
On Fri, Jul 15, 2016 at 11:28 PM, Eric Wong wrote: > Konstantin Khomoutov wrote: >> Ben Peart wrote: >> > > Lars Schneider wrote: >> > > >> > > We could dynamically load libraries but this would force us to >> > > freeze the ABI as mentioned by Duy: >> > > http://article.gmane.org/gmane.comp.ver

Re: [ANNOUNCE] Git v2.9.1

2016-07-15 Thread Duy Nguyen
On Thu, Jul 14, 2016 at 9:38 AM, Lars Schneider wrote: > > On 13 Jul 2016, at 22:43, Junio C Hamano wrote: > >> Junio C Hamano writes: >> >>> It is somewhat disturbing that nobody seems to be regularly building >>> on 32-bit platforms these days, which is the only reason I can think >>> of why t

Re: Bug in index-helper/watchman?

2016-07-15 Thread Duy Nguyen
On Thu, Jul 14, 2016 at 5:21 PM, Duy Nguyen wrote: >> On Thu, Jul 14, 2016 at 12:11 AM, Ben Peart wrote: >>> I’ve been chasing down an issue where it looks like the untracked cache >>> logic doesn’t work correctly in the index-helper/watchman patch series. >>>

Re: Bug in index-helper/watchman?

2016-07-15 Thread Duy Nguyen
On Sat, Jul 16, 2016 at 08:10:15AM +0200, Duy Nguyen wrote: > But you did spot a problem. What if UC extension is loaded _after_ > watchman one? Then index->untracked_cache would have nothing in there > and invalidation is no-op when we do it (at watchmain ext loading > time). W

Re: [PATCH v2 2/2] archive-tar: huge offset and future timestamps would not work on 32-bit

2016-07-15 Thread Duy Nguyen
On Fri, Jul 15, 2016 at 12:36 AM, Junio C Hamano wrote: > Jeff King writes: > >> On Thu, Jul 14, 2016 at 01:43:57PM -0700, Junio C Hamano wrote: >> >>> As we are not yet moving everything to size_t but still using ulong >>> internally when talking about the size of object, platforms with >>> 32-b

Re: [PATCH v4] config: add conditional include

2016-07-16 Thread Duy Nguyen
On Sat, Jul 16, 2016 at 3:30 PM, Johannes Schindelin wrote: > As an alternative solution to your problem, you could of course avoid all > conditional includes. Simply by adding the include.path settings > explicitly to the configs that require them. Now, that would make reasoning > and trouble-sho

Re: Git and SHA-1 security (again)

2016-07-17 Thread Duy Nguyen
On Sun, Jul 17, 2016 at 4:21 PM, brian m. carlson wrote: > On Sun, Jul 17, 2016 at 10:01:38AM +0200, Johannes Schindelin wrote: >> Out of curiosity: have you considered something like padding the SHA-1s >> with, say 0xa1, to the size of the new hash and using that padding to >> distinguish between

Re: Git and SHA-1 security (again)

2016-07-18 Thread Duy Nguyen
On Mon, Jul 18, 2016 at 5:57 PM, Johannes Schindelin wrote: > Hi Zsolt, > > On Mon, 18 Jul 2016, Herczeg Zsolt wrote: > >> >> I think converting is a much better option. Use a single-hash >> >> storage, and convert everything to that on import/clone/pull. >> > >> > That ignores two very important

Re: Git and SHA-1 security (again)

2016-07-18 Thread Duy Nguyen
On Sun, Jul 17, 2016 at 4:21 PM, brian m. carlson wrote: > I'm going to end up having to do something similar because of the issue > of submodules. Submodules may still be SHA-1, while the main repo may > be a newer hash. Or even the other way around, main repo is one with sha1 while submodule i

Re: Git and SHA-1 security (again)

2016-07-19 Thread Duy Nguyen
On Tue, Jul 19, 2016 at 9:18 AM, Johannes Schindelin wrote: >> But we can recreate SHA-1 from the same content and verify GPG, right? >> I know it's super expensive, but it feels safer to not carry SHA-1 >> around when it's not secure anymore (I recall something about >> exploiting the weakest lin

Re: Git and SHA-1 security (again)

2016-07-19 Thread Duy Nguyen
On Mon, Jul 18, 2016 at 6:51 PM, Duy Nguyen wrote: > On Sun, Jul 17, 2016 at 4:21 PM, brian m. carlson > wrote: >> I'm going to end up having to do something similar because of the issue >> of submodules. Submodules may still be SHA-1, while the main repo may >> be

Re: t7063 failure on FreeBSD 10.3 i386/amd64

2016-07-19 Thread Duy Nguyen
On Tue, Jul 19, 2016 at 12:54 AM, Eric Wong wrote: > Oops, forgot to Cc some folks who worked on this :x > > Filesystem is ufs and it fails regardless of whether > soft-updates is enabled or not. Nothing stands out to my eyes, so I'm going to install freebsd this weekend. I hope ufs does not have

Re: Git and SHA-1 security (again)

2016-07-19 Thread Duy Nguyen
On Tue, Jul 19, 2016 at 7:06 PM, Junio C Hamano wrote: > Duy Nguyen writes: > >> Post-shower thoughts. In a tree object, a submodule entry consists of >> perm (S_IFGITLINK), hash (which is the external hash) and path. We >> could fill the "hash" part with a

Re: Git and SHA-1 security (again)

2016-07-19 Thread Duy Nguyen
On Tue, Jul 19, 2016 at 7:34 PM, David Lang wrote: > On Tue, 19 Jul 2016, Duy Nguyen wrote: > >> On Tue, Jul 19, 2016 at 9:18 AM, Johannes Schindelin >> wrote: >>>> >>>> But we can recreate SHA-1 from the same content and verify GPG, right? >>>&

Re: Git and SHA-1 security (again)

2016-07-19 Thread Duy Nguyen
On Tue, Jul 19, 2016 at 7:59 PM, David Lang wrote: > On Tue, 19 Jul 2016, Duy Nguyen wrote: > >> On Tue, Jul 19, 2016 at 7:34 PM, David Lang wrote: >>> >>> On Tue, 19 Jul 2016, Duy Nguyen wrote: >>> >>>> On Tue, Jul 19, 2016 at 9:18 AM, Johann

Re: [PATCH] worktree: add: introduce the --name option

2016-07-19 Thread Duy Nguyen
On Tue, Jul 19, 2016 at 8:04 PM, Junio C Hamano wrote: > Antoine Tenart writes: > >> Adds a --name option allowing to specify the name of a worktree when >> creating it. This allows to have multiple worktrees in directories >> having the same name (e.g. project0/foo, project1/foo etc...). This >>

Re: [PATCH] worktree: add: introduce the --name option

2016-07-19 Thread Duy Nguyen
On Tue, Jul 19, 2016 at 8:54 PM, Antoine Tenart wrote: > On Tue, Jul 19, 2016 at 08:23:58PM +0200, Duy Nguyen wrote: >> On Tue, Jul 19, 2016 at 8:04 PM, Junio C Hamano wrote: >> >> 080739b (worktree.c: find_worktree() search by path suffix - >> 2016-06-13) from

Re: Current state of Git worktree used with submodules?

2016-07-19 Thread Duy Nguyen
On Tue, Jul 19, 2016 at 10:59 PM, Lars Schneider wrote: > Hi, > > some time ago Michael wrote in a blog post [1]: > "It's not recommended to use git worktree with a repository that contains > submodules." > > Plus "Documentation/git-worktree.txt" states: > "Multiple checkout in general is still e

Re: Git and SHA-1 security (again)

2016-07-20 Thread Duy Nguyen
On Wed, Jul 20, 2016 at 2:28 PM, Johannes Schindelin wrote: > But that strategy *still* ignores the distributed nature of Git. Just > because *you* make that merge at a certain point does not necessarily mean > that I make it at that point, too. > > Any approach that tries to have one single point

Re: Git and SHA-1 security (again)

2016-07-20 Thread Duy Nguyen
On Tue, Jul 19, 2016 at 8:58 PM, Herczeg Zsolt wrote: > 2016-07-19 20:04 GMT+02:00 Duy Nguyen : >> On Tue, Jul 19, 2016 at 7:59 PM, David Lang wrote: >>> On Tue, 19 Jul 2016, Duy Nguyen wrote: >>> >>>> On Tue, Jul 19, 2016 at 7:34 PM, David Lang wrot

Re: [PATCH] worktree: add: introduce the --name option

2016-07-20 Thread Duy Nguyen
On Tue, Jul 19, 2016 at 9:35 PM, Antoine Tenart wrote: > On Tue, Jul 19, 2016 at 09:04:11PM +0200, Duy Nguyen wrote: >> On Tue, Jul 19, 2016 at 8:54 PM, Antoine Tenart >> wrote: >> > On Tue, Jul 19, 2016 at 08:23:58PM +0200, Duy Nguyen wrote: >> >> On T

Re: t7063 failure on FreeBSD 10.3 i386/amd64

2016-07-20 Thread Duy Nguyen
On Wed, Jul 20, 2016 at 5:02 AM, Eric Wong wrote: > Duy Nguyen wrote: >> On Tue, Jul 19, 2016 at 12:54 AM, Eric Wong wrote: >> > Oops, forgot to Cc some folks who worked on this :x >> > >> > Filesystem is ufs and it fails regardless of whether >> >

Re: [PATCH v4 3/4] submodule: support running in multiple worktree setup

2016-07-22 Thread Duy Nguyen
On Thu, Jul 21, 2016 at 1:22 AM, Stefan Beller wrote: > On Wed, Jul 20, 2016 at 10:24 AM, Nguyễn Thái Ngọc Duy > wrote: >> Signed-off-by: Nguyễn Thái Ngọc Duy >> --- >> Documentation/git-worktree.txt | 8 >> git-submodule.sh | 8 >> 2 files changed, 12 insertions

Re: [PATCH v4 2/4] submodule: update core.worktree using git-config

2016-07-22 Thread Duy Nguyen
On Thu, Jul 21, 2016 at 12:04 AM, Stefan Beller wrote: >> diff --git a/submodule.c b/submodule.c >> index abc2ac2..b912871 100644 >> --- a/submodule.c >> +++ b/submodule.c >> @@ -1128,7 +1128,9 @@ void connect_work_tree_and_git_dir(const char >> *work_tree, const char *git_dir) >> { >> s

Re: [PATCH v4 3/4] submodule: support running in multiple worktree setup

2016-07-22 Thread Duy Nguyen
On Fri, Jul 22, 2016 at 7:25 PM, Stefan Beller wrote: > On Fri, Jul 22, 2016 at 10:09 AM, Duy Nguyen wrote: >> >> I just quickly glanced through the rest of this mail because, as a >> submodule ignorant, it's just mumbo jumbo to me. But what I see here >> is, th

Re: [PATCH 00/10] git worktree (re)move

2016-07-23 Thread Duy Nguyen
On Sat, Jun 25, 2016 at 9:54 AM, Nguyễn Thái Ngọc Duy wrote: > Now that nd/worktree-lock seems to be on its way to 'next', let's > continue to review this one. The first 5 patches bring busybox's copy > functionality to git. The last 5 add support functions and the two new > commands. Mostly a no

Re: [PATCH v1 3/3] convert: add filter..useProtocol option

2016-07-25 Thread Duy Nguyen
On Sun, Jul 24, 2016 at 9:11 PM, Lars Schneider wrote: > > On 23 Jul 2016, at 10:14, Eric Wong wrote: > >> larsxschnei...@gmail.com wrote: >>> Please note that the protocol filters do not support stream processing >>> with this implemenatation because the filter needs to know the length of >>> th

Re: [RFC/PATCH 0/8] Add configuration options for split-index

2016-07-25 Thread Duy Nguyen
On Sat, Jul 23, 2016 at 6:11 PM, Christian Couder wrote: > Ok, I started working on automatically pushing back all changes to the > shared index when the percentage of entries in linked vs shared > indexes is greater than 25% (maybe I will make it configurable later). > It is very basic and doesn'

Re: [PATCH] t5510: become resilient to GETTEXT_POISON

2016-07-25 Thread Duy Nguyen
On Mon, Jul 25, 2016 at 5:16 PM, Junio C Hamano wrote: > On Mon, Jul 25, 2016 at 2:31 AM, Vasco Almeida wrote: >> Replace gettext poison text with appropriate values to be able to cut >> the right output of git fetch command for comparison. > > Hmm, as these tests are _all_ about human-readable o

Re: [PATCH] config.mak.uname: correct perl path on FreeBSD

2016-07-25 Thread Duy Nguyen
On Mon, Jul 25, 2016 at 6:56 PM, Junio C Hamano wrote: > On Mon, Jul 25, 2016 at 9:21 AM, Nguyễn Thái Ngọc Duy > wrote: >> It looks the the symlink /usr/bin/perl (to /usr/local/bin/perl) has >> been removed at least on FreeBSD 10.3. See [1] for more information. >> >> [1] >> https://svnweb.free

Re: [PATCH v4 1/4] worktree: add per-worktree config files

2016-07-26 Thread Duy Nguyen
On Tue, Jul 26, 2016 at 2:59 AM, Stefan Beller wrote: > I like the user facing design, but how am I supposed to use it internally? > > Say I want to read a value preferably from the worktree I'd do a > /* > * maybe I don't even have to set it to 1 as > * the user is supposed to do th

Re: [PATCH v4 3/4] submodule: support running in multiple worktree setup

2016-07-26 Thread Duy Nguyen
On Tue, Jul 26, 2016 at 1:25 AM, Stefan Beller wrote: > So what is the design philosophy in worktrees? How much independence does > one working tree have? git-worktree started out as an alternative for git-stash: hmm.. i need to make some changes in another branch, okay let's leave this worktree

Re: [PATCH v4 3/4] submodule: support running in multiple worktree setup

2016-07-27 Thread Duy Nguyen
On Wed, Jul 27, 2016 at 6:10 AM, Max Kirillov wrote: > Hi. > > On Wed, Jul 20, 2016 at 07:24:18PM +0200, Nguyễn Thái Ngọc Duy wrote: >> + - `remote.*` added by submodules may be per working directory as >> + well, unless you are sure remotes from all possible submodules in >> + history are con

Re: [PATCH v8 32/41] environment: add set_index_file()

2016-07-27 Thread Duy Nguyen
On Tue, Jul 26, 2016 at 9:28 PM, Junio C Hamano wrote: > Christian Couder writes: > >> Introduce set_index_file() to be able to temporarily change the index file. >> >> It should be used like this: >> >> /* Save current index file */ >> old_index_file = get_index_file(); >> set_index_

Re: [PATCH v4 3/4] submodule: support running in multiple worktree setup

2016-07-27 Thread Duy Nguyen
On Tue, Jul 26, 2016 at 8:15 PM, Stefan Beller wrote: >> How to store stuff in .git is the implementation details that the user >> does not care about. > > They do unfortunately. :( Well.. i mean the structure of .git. If .git gets big, yeah many people will get pissed. > My sudden interest in w

Re: t7063 failure on FreeBSD 10.3 i386/amd64

2016-07-27 Thread Duy Nguyen
On Tue, Jul 19, 2016 at 6:12 PM, Duy Nguyen wrote: > On Tue, Jul 19, 2016 at 12:54 AM, Eric Wong wrote: >> Oops, forgot to Cc some folks who worked on this :x >> >> Filesystem is ufs and it fails regardless of whether >> soft-updates is enabled or not. > > Noth

Find a topic branch containing a commit

2016-07-27 Thread Duy Nguyen
Before I start doing anything silly because I don't know it can already be done without waving my C wand like a mad man... I often do this: find a commit of interest, the commit itself is not enough so I need a full patch series to figure out what's going, so I fire up "git log --graph --oneline"

Re: Find a topic branch containing a commit

2016-07-27 Thread Duy Nguyen
On Wed, Jul 27, 2016 at 8:02 PM, Stefan Beller wrote: > On Wed, Jul 27, 2016 at 10:50 AM, Stefan Beller wrote: >>> >>> PS. Sometimes I wish we could optionally save cover letter in the >>> merge commit. Sometimes the "big plan" is hard to see by reading >>> individual commit messages. >>> -- > >

Re: Find a topic branch containing a commit

2016-07-27 Thread Duy Nguyen
On Wed, Jul 27, 2016 at 7:50 PM, Stefan Beller wrote: > On Wed, Jul 27, 2016 at 10:42 AM, Duy Nguyen wrote: >> Before I start doing anything silly because I don't know it can >> already be done without waving my C wand like a mad man... >> >> I often do this

Re: [PATCH/RFC 0/7] Add possibility to clone specific subdirectories

2016-07-28 Thread Duy Nguyen
On Thu, Jul 28, 2016 at 6:02 PM, Robin Ruede wrote: > This patch series adds a `--sparse-prefix=` option to multiple commands, > allowing fetching repository contents from only a subdirectory of a remote. > > This works along with sparse-checkout, and is especially useful for > repositories > whe

Re: [PATCH/RFC 0/7] Add possibility to clone specific subdirectories

2016-07-28 Thread Duy Nguyen
Corrections.. On Thu, Jul 28, 2016 at 6:59 PM, Duy Nguyen wrote: > Ah.. this is what I call narrow checkout [1] (but gmane is down at the moment) s/checkout/clone/ > [2] https://github.com/pclouds/git/commits/lanh/narrow-checkout s,lanh/,, -- Duy -- To unsubscribe from this list: se

Re: Alternatives to mid.gmane.org?

2016-07-28 Thread Duy Nguyen
On Thu, Jul 28, 2016 at 11:11 AM, Lars Schneider wrote: > Hi, > > gmane is down I read this and thought "temporarily" but apparently it's not [1]. A lot of our links in the mail archive are gmane's :( [1] https://lars.ingebrigtsen.no/2016/07/28/the-end-of-gmane/ -- Duy -- To unsubscribe from th

Re: [PATCH v8 32/41] environment: add set_index_file()

2016-07-29 Thread Duy Nguyen
On Fri, Jul 29, 2016 at 4:21 PM, Christian Couder wrote: >> I agree we should avoid this. There's a bunch of cache_name_pos() (and >> even read_cache()) in the libified apply.c, those will need to be >> converted to take struct index_state* directly (read_index_from or >> index_name_pos). > > The

Re: [PATCH/RFC 0/7] Add possibility to clone specific subdirectories

2016-07-29 Thread Duy Nguyen
On Thu, Jul 28, 2016 at 10:33 PM, Junio C Hamano wrote: > Duy Nguyen writes: > >>> 4. Fsck complains about missing blobs. Should be fairly easy to fix. >> >> Not really. You'll have to associate path information with blobs >> before you decide that a blob

Re: [PATCH v8 32/41] environment: add set_index_file()

2016-07-29 Thread Duy Nguyen
On Fri, Jul 29, 2016 at 8:23 PM, Christian Couder wrote: > On Fri, Jul 29, 2016 at 5:34 PM, Duy Nguyen wrote: >> >> Yeah. If the libification movement is going strong, we can start >> converting and at some point should be able to define >> NO_THE_INDEX_COMPATIBILITY

Re: t7063 failure on FreeBSD 10.3 i386/amd64

2016-07-30 Thread Duy Nguyen
On Wed, Jul 27, 2016 at 07:33:17PM +0200, Duy Nguyen wrote: > On Tue, Jul 19, 2016 at 6:12 PM, Duy Nguyen wrote: > > On Tue, Jul 19, 2016 at 12:54 AM, Eric Wong wrote: > >> Oops, forgot to Cc some folks who worked on this :x > >> > >> Filesystem is uf

Re: t7063 failure on FreeBSD 10.3 i386/amd64

2016-07-30 Thread Duy Nguyen
On Sat, Jul 30, 2016 at 3:31 PM, Duy Nguyen wrote: > I give up. I lied. Sleeping 30 seconds in that test case works, but there is no way I'm sending a patch to delay 30 seconds. FreeBSD must have some delayed mtime update "feature" in its vfs layer somewhere. Now I give

Re: [PATCH] t7063: work around FreeBSD's lazy mtime update feature

2016-07-31 Thread Duy Nguyen
On Sun, Jul 31, 2016 at 3:07 AM, Eric Wong wrote: >> would be more to the point of what is going on, here. But I >> also wonder if untracked cache itself could/should be doing this >> internally. > > Still wondering :> There's nothing we can do besides maybe run a cron job executing 'sync' ever

Re: [PATCH] t7063: work around FreeBSD's lazy mtime update feature

2016-08-01 Thread Duy Nguyen
On Mon, Aug 1, 2016 at 3:37 AM, Torstem Bögershausen wrote: > the term FREEBSD may be too generic to point out a single feature > in an OS distributution. > Following your investigations, it may even be possible that > other systems adapt this "feature"? > > How about > LAZY_DIR_MTIME_UPDATE > (or

Re: [PATCH 1/2] pager: move pager-specific setup into the build

2016-08-01 Thread Duy Nguyen
On Mon, Aug 1, 2016 at 3:05 AM, Eric Wong wrote: > From: Junio C Hamano > > Allowing PAGER_ENV to be set at build-time allows us to move > pager-specific knowledge out of our build. Currently, this > allows us to set a better default for FreeBSD where more(1) > is the same binary as less(1). Ni

Re: [PATCH 1/2] pager: move pager-specific setup into the build

2016-08-01 Thread Duy Nguyen
On Mon, Aug 1, 2016 at 7:52 PM, Jeff King wrote: > On Mon, Aug 01, 2016 at 07:46:34PM +0200, Duy Nguyen wrote: > >> On Mon, Aug 1, 2016 at 3:05 AM, Eric Wong wrote: >> > From: Junio C Hamano >> > >> > Allowing PAGER_ENV to be set at build-time allows us to

Re: [PATCH] t7063: work around FreeBSD's lazy mtime update feature

2016-08-02 Thread Duy Nguyen
On Mon, Aug 01, 2016 at 02:04:44PM -0700, Junio C Hamano wrote: > Duy Nguyen writes: > > > On Mon, Aug 1, 2016 at 3:37 AM, Torstem Bögershausen wrote: > >> the term FREEBSD may be too generic to point out a single feature > >> in an OS distributution. > >>

Re: [PATCH v2] t7063: work around FreeBSD's lazy mtime update feature

2016-08-03 Thread Duy Nguyen
On Wed, Aug 3, 2016 at 6:16 PM, Junio C Hamano wrote: > Nguyễn Thái Ngọc Duy writes: > >> v2 goes with Junio's suggestion (good one!). > > Ehh, have you even read what you copied and pasted? "this and that" > and "blah" are meant to be placeholders for you to fill in. I did. But after a bit o

Re: [PATCH v3] t7063: work around FreeBSD's lazy mtime update feature

2016-08-04 Thread Duy Nguyen
On Wed, Aug 3, 2016 at 9:07 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> If you mean to tell the user "I won't describe it in detail, if you >> really want to know, >> go run blame yourself", spell it out like so. I was hoping that you >> can summarize >> in-line there to help the read

Re: patch submission process, was Re: [PATCH v6 06/16] merge_recursive: abort properly upon errors

2016-08-05 Thread Duy Nguyen
On Wed, Aug 3, 2016 at 6:07 PM, Johannes Schindelin wrote: > It would be a totally different matter, of course, if you used the > branches I publish via my GitHub repository, added fixup! and squash! > commits, published the result to a public repository and then told me to > pull from there, that

Re: [ANNOUNCE] more archives of this list

2016-08-05 Thread Duy Nguyen
On Fri, Aug 5, 2016 at 11:28 AM, Jeff King wrote: > There was discussion a long time ago about storing a common zlib > dictionary in the packfile and using it for all of the objects. I don't > recall whether there were any patches, though. It does create some > complications with serving clones/fe

Re: storing cover letter of a patch series?

2016-08-07 Thread Duy Nguyen
On Sun, Aug 7, 2016 at 7:12 AM, Michael S. Tsirkin wrote: > On Fri, Aug 05, 2016 at 08:39:58AM -0700, Junio C Hamano wrote: >> "Michael S. Tsirkin" writes: >> >> > On Thu, Sep 10, 2015 at 11:39:49AM -0700, Junio C Hamano wrote: >> >> The problem with "empty commit trick" is that it is a commit wh

Re: patch submission process, was Re: [PATCH v6 06/16] merge_recursive: abort properly upon errors

2016-08-08 Thread Duy Nguyen
On Tue, Aug 9, 2016 at 12:20 AM, Michael Haggerty wrote: > On 08/04/2016 05:58 PM, Johannes Schindelin wrote: >> [...] >> Even requiring every contributor to register with GitHub would be too much >> of a limitation, I would wager. >> [...] > > Is it *really* so insane to consider moving collabora

Re: patch submission process, was Re: [PATCH v6 06/16] merge_recursive: abort properly upon errors

2016-08-09 Thread Duy Nguyen
On Tue, Aug 9, 2016 at 1:20 AM, Michael Haggerty wrote: > Could you elaborate why you would expect quality and/or quantity of > reviews to suffer? I'm really curious, and I'd be happy to pass your > feedback along to my colleagues. Since I have been using github at work for a couple months, I do

Re: patch submission process, was Re: [PATCH v6 06/16] merge_recursive: abort properly upon errors

2016-08-09 Thread Duy Nguyen
On Tue, Aug 9, 2016 at 8:36 PM, Duy Nguyen wrote: > On Tue, Aug 9, 2016 at 1:20 AM, Michael Haggerty wrote: >> Could you elaborate why you would expect quality and/or quantity of >> reviews to suffer? I'm really curious, and I'd be happy to pass your >> feedback al

Re: patch submission process, was Re: [PATCH v6 06/16] merge_recursive: abort properly upon errors

2016-08-09 Thread Duy Nguyen
On Tue, Aug 9, 2016 at 1:37 PM, Jeff King wrote: >That's (relatively) easy for me to script via mutt (grab >these patches, apply them). Could you share your mutt set up pleaaase? I've been wanting this for a long time, but never used mutt long enough to bother with a proper setup like thi

Re: "disabling bitmap writing, as some objects are not being packed"?

2016-12-16 Thread Duy Nguyen
On Sat, Dec 17, 2016 at 4:28 AM, Junio C Hamano wrote: > David Turner writes: > >> I'm a bit confused by the message "disabling bitmap writing, as some >> objects are not being packed". I see it the my gc.log file on my git >> server. > >> 1. Its presence in the gc.log file prevents future autom

Re: [PATCH 1/2] alternates: accept double-quoted paths

2016-12-16 Thread Duy Nguyen
On Wed, Dec 14, 2016 at 1:08 AM, Junio C Hamano wrote: > Duy Nguyen writes: > >> At least attr has the same problem and is going the same direction >> [1]. Cool. (I actually thought the patch was in and evidence that this >> kind of backward compatibility breaking was

Re: [PATCHv8 6/6] submodule: add absorb-git-dir function

2016-12-18 Thread Duy Nguyen
On Mon, Dec 12, 2016 at 11:04:35AM -0800, Stefan Beller wrote: > diff --git a/dir.c b/dir.c > index e0efd3c2c3..d872cc1570 100644 > --- a/dir.c > +++ b/dir.c > @@ -2773,3 +2773,15 @@ void connect_work_tree_and_git_dir(const char > *work_tree_, const char *git_dir_) > free(work_tree); >

Re: [PATCH v2 02/21] config: add git_config_get_split_index()

2016-12-19 Thread Duy Nguyen
On Sat, Dec 17, 2016 at 03:55:28PM +0100, Christian Couder wrote: > diff --git a/config.c b/config.c > index 2eaf8ad77a..c1343bbb3e 100644 > --- a/config.c > +++ b/config.c > @@ -1709,6 +1709,16 @@ int git_config_get_untracked_cache(void) > return -1; /* default value */ > } > > +int git_c

Re: [PATCH v2 04/21] read-cache: add and then use tweak_split_index()

2016-12-19 Thread Duy Nguyen
On Sat, Dec 17, 2016 at 03:55:30PM +0100, Christian Couder wrote: > +static void tweak_split_index(struct index_state *istate) > +{ > + switch (git_config_get_split_index()) { > + case -1: /* unset: do nothing */ > + break; > + case 0: /* false */ > + remove_spli

Re: [PATCH v2 10/21] read-cache: regenerate shared index if necessary

2016-12-19 Thread Duy Nguyen
On Sat, Dec 17, 2016 at 03:55:36PM +0100, Christian Couder wrote: > +static const int default_max_percent_split_change = 20; > + > +static int too_many_not_shared_entries(struct index_state *istate) > +{ > + int i, not_shared = 0; > + int max_split = git_config_get_max_percent_split_change(

Re: [PATCH v2 16/21] read-cache: unlink old sharedindex files

2016-12-19 Thread Duy Nguyen
On Sat, Dec 17, 2016 at 03:55:42PM +0100, Christian Couder wrote: > +static int clean_shared_index_files(const char *current_hex) > +{ > + struct dirent *de; > + DIR *dir = opendir(get_git_dir()); > + > + if (!dir) > + return error_errno(_("unable to open git dir: %s"), > g

Re: [PATCH v2 00/21] Add configuration options for split-index

2016-12-19 Thread Duy Nguyen
On Sat, Dec 17, 2016 at 03:55:26PM +0100, Christian Couder wrote: > Goal > > > We want to make it possible to use the split-index feature > automatically by just setting a new "core.splitIndex" configuration > variable to true. > > This can be valuable as split-index can help significantly s

<    1   2   3   4   5   6   7   8   9   10   >